Explicitly use Qt4 #5
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
astrofrog
force-pushed
the
fix-pyqt-4
branch
from
5f30a21 to
9f8c6df
Compare
astrofrog
force-pushed
the
fix-pyqt-4
branch
from
9f8c6df to
6f25cde
Compare
…ntry points) dependency
| - qtconsole | ||
| - xlrd | ||
| - scikit-image | ||
| - python.app # [osx] | ||
| - setuptools |
There was a problem hiding this comment.
Do we need it at run time too?
There was a problem hiding this comment.
Yes, for entry point discovery (for plugins)
There was a problem hiding this comment.
(We import pkg_ressources at run-time)
There was a problem hiding this comment.
Ah for plugins too. Not just the entry points. Ok.
| @@ -10,14 +10,15 @@ source: | |||
| md5: 92dd7de2621a6ab6861cc9b689e86c3e | |||
|
|
|||
| build: | |||
| number: 0 | |||
| number: 1 | |||
| script: python setup.py install --single-version-externally-managed --record record.txt | |||
| osx_is_app: True | |||
There was a problem hiding this comment.
Please add the entry points here.
There was a problem hiding this comment.
@jakirkham - the app entry point is already included in the app section lower down - do I need to add it up here too?
There was a problem hiding this comment.
Does it really make sense to duplicate the entry points if they are already in setup.py by the way? (for the non-app ones)
There was a problem hiding this comment.
It does as we do not want to include the setuptools-based entry points. This will replace them with conda's. In the long run, maybe using pip will be a better solution, but things are a bit broken on Windows ATM. See this comment for details.
|
Please add the license file using |
Qt5 support will work properly with glueviz 0.9