-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build all libraries in the package #125
Conversation
By default `google-cloud-cpp` only builds the most commonly used libraries. When building from source that can save some time, but for package managers this leaves out many important features.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks for this @coryan! W.r.t to protobuf, looking at some of the issues (e.g. googleapis/google-cloud-cpp#8145), it says that it needs protobuf >3.19.3; however we're at 3.21.12 already1 - does that change anything? Footnotes
|
It is a sad, sad story. We thought it only affected macOS, the fixes are in. But it also affects Windows, and I cannot find any fixes for that. I will need to send new patches.
Things are moving. There are two release candidates for v22.0. |
OK good to know thanks. If the patches aren't too big we can already carry them in conda-forge (within reason).
Breaking ABI and/or API? The former is a given (what we've been dealing with so far; just recompile), the latter would be harder to deal with, because it'll possibly need source adaptation). |
The 4 might just be for the python release, at least that's how it's been since 3.21.0. The tag is the same for 3.22.0, 4.22.0 & 22.0:
This broke our bot in creative ways when it was rolled out, but my request to distinguish the tag patterns was rejected. |
I will share a link to the patches as soon as they get exported. I think they amount to 12 lines changed across 4 files.
Both. You can see a partial list of changes in the v22.0-rc1 Release Notes. Notable ones that I think affect Conda:
See the release notes, they explicitly call out breaking changes to C++ and Ruby. |
Yeah, and I just found https://github.com/protocolbuffers/protobuf/blob/main/version.json, which notes the major versions. |
By default
google-cloud-cpp
only builds the most commonly used libraries. When building from source that can save some time, but for package managers this leaves out many important features.Checklist
0
(if the version changed)Fixes #115
I had to leave out a few libraries (
google/cloud/asset
,google/cloud/channel
, andgoogle/cloud/storagetransfer
). The proto files for these libraries use enum value names (e.g.DOMAIN
) which are also defined as macros in the system libraries or in the C++ standard library. With all but the latest version of Protobuf this is not a problem. With older versions it can be a problem with some compilers and C++ standard libraries (the list seems really hard to nail down).