Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to potentially fix https://github.com/conda-forge/gz-sim-feedstock/pull/9, fix autotick bot #7

Merged
merged 42 commits into from
Jun 8, 2023

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Jan 22, 2023

Two changes:

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor

traversaro commented Jan 22, 2023

There is an error related to the use of dart 6.13, we probably need to update gz-physics to get gazebosim/gz-physics#465 (unfortunatly there are no automatic updates due to conda-forge/libignition-gazebo-feedstock#24 and similar issues).

@traversaro
Copy link
Contributor

traversaro commented Jan 22, 2023

There is an error related to the use of dart 6.13, we probably need to update gz-physics to get gazebosim/gz-physics#465 (unfortunatly there are no automatic updates due to conda-forge/libignition-gazebo-feedstock#24 and similar issues).

Ah unfortunatly gazebo-physics 6.3.0 still needs to updated (see gazebosim/gz-physics#474), so we can just backport the dartsim 6.13 fixes.

@traversaro
Copy link
Contributor

There is an error related to the use of dart 6.13, we probably need to update gz-physics to get gazebosim/gz-physics#465 (unfortunatly there are no automatic updates due to conda-forge/libignition-gazebo-feedstock#24 and similar issues).

Ah unfortunatly gazebo-physics 6.3.0 still needs to updated (see gazebosim/gz-physics#474), so we can just backport the dartsim 6.13 fixes.

The patch does not apply cleanly, at this point we can fix to dartsim 6.12 until gazebo-physics 6.3.0 is released.

@Tobias-Fischer Tobias-Fischer added the automerge Merge the PR when CI passes label Jan 23, 2023
@Tobias-Fischer
Copy link
Contributor Author

Hmm .. some test failures on windows now :(


D:\bld\gz-physics6_1674432363764\work\test\common_test\simulation_features.cc(107): Skipped

[  SKIPPED ] SimulationFeaturesTestFeaturesContactPropertiesCallback/0.ContactPropertiesCallback (0 ms)
[----------] 1 test from SimulationFeaturesTestFeaturesContactPropertiesCallback/0 (0 ms total)

[----------] Global test environment tear-down
[==========] 9 tests from 6 test suites ran. (928 ms total)
[  PASSED  ] 2 tests.
[  SKIPPED ] 5 tests, listed below:
[  SKIPPED ] SimulationFeaturesTestBasic/0.FreeGroup
[  SKIPPED ] SimulationFeaturesTestBasic/0.ShapeBoundingBox
[  SKIPPED ] SimulationFeaturesTestBasic/0.CollideBitmasks
[  SKIPPED ] SimulationFeaturesTestBasic/0.RetrieveContacts
[  SKIPPED ] SimulationFeaturesTestFeaturesContactPropertiesCallback/0.ContactPropertiesCallback
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] SimulationFeaturesStepTest/0.StepWorld, where TypeParam = struct gz::physics::FeatureList<class gz::physics::sdf::ConstructSdfWorld,class gz::physics::ForwardStep>
[  FAILED  ] SimulationFeaturesShapeFeaturesTest/0.ShapeFeatures, where TypeParam = struct gz::physics::FeatureList<class gz::physics::sdf::ConstructSdfWorld,class gz::physics::GetModelFromWorld,class gz::physics::GetLinkFromModel,class gz::physics::GetShapeFromLink,class gz::physics::GetModelBoundingBox,class gz::physics::ForwardStep,class gz::physics::AttachBoxShapeFeature,class gz::physics::AttachSphereShapeFeature,class gz::physics::AttachCylinderShapeFeature,class gz::physics::AttachEllipsoidShapeFeature,class gz::physics::AttachCapsuleShapeFeature,class gz::physics::GetSphereShapeProperties,class gz::physics::GetBoxShapeProperties,class gz::physics::GetCylinderShapeProperties,class gz::physics::GetCapsuleShapeProperties,class gz::physics::GetEllipsoidShapeProperties>

 2 FAILED TESTS

@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@traversaro
Copy link
Contributor

traversaro commented Jan 23, 2023

Just to be sure I will update to last version the dependencies:

@traversaro traversaro changed the title Bump to potentially fix https://github.com/conda-forge/gz-sim-feedstock/pull/9 Bump to potentially fix https://github.com/conda-forge/gz-sim-feedstock/pull/9 and fix autotick bot Feb 6, 2023
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@traversaro
Copy link
Contributor

Integration tests on Windows are failing with:


D:\bld\gz-physics6_1675720288567\work\test\integration\FrameSemantics.hh(336) : fatal error C1002: compiler is out of heap space in pass 2

LINK : fatal error LNK1257: code generation failed

Let's see if it works with one thread.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/gz-physics-feedstock/actions/runs/5200683715.

@traversaro
Copy link
Contributor

Current problem is:

[82/156] cmd.exe /C "cd . && D:\bld\gz-physics6_1686145251501\_build_env\Library\bin\cmake.exe -E vs_link_exe --intdir=dartsim\CMakeFiles\UNIT_Base_TEST.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1434~1.319\bin\HostX64\x64\link.exe  dartsim\CMakeFiles\UNIT_Base_TEST.dir\src\Base_TEST.cc.obj  /out:bin\UNIT_Base_TEST.exe /implib:lib\UNIT_Base_TEST.lib /pdb:bin\UNIT_Base_TEST.pdb /version:0.0 /machine:x64 /INCREMENTAL:NO /subsystem:console  lib\gtest.lib  lib\gtest_main.lib  lib\gz-physics6-dartsim-plugin.lib  lib\gtest.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-collision-bullet.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\BulletDynamics.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\BulletCollision.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\LinearMath.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\BulletSoftBody.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-collision-ode.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\ode_double.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-utils-urdf.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-utils.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\tinyxml2.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\urdfdom_sensor.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\urdfdom_model_state.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\urdfdom_model.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\urdfdom_world.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\console_bridge.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-external-odelcpsolver.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\fcl.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\ccd.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\octomap.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\octomath.lib  -lpthreads  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\fmt.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\octomap.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\octomath.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\sdformat13.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-common5-geospatial.lib  lib\gz-physics6.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-common5-graphics.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-common5.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\assimp.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\z.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-math7.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-plugin2-loader.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-plugin2.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-utils2.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
FAILED: bin/UNIT_Base_TEST.exe 
cmd.exe /C "cd . && D:\bld\gz-physics6_1686145251501\_build_env\Library\bin\cmake.exe -E vs_link_exe --intdir=dartsim\CMakeFiles\UNIT_Base_TEST.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1434~1.319\bin\HostX64\x64\link.exe  dartsim\CMakeFiles\UNIT_Base_TEST.dir\src\Base_TEST.cc.obj  /out:bin\UNIT_Base_TEST.exe /implib:lib\UNIT_Base_TEST.lib /pdb:bin\UNIT_Base_TEST.pdb /version:0.0 /machine:x64 /INCREMENTAL:NO /subsystem:console  lib\gtest.lib  lib\gtest_main.lib  lib\gz-physics6-dartsim-plugin.lib  lib\gtest.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-collision-bullet.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\BulletDynamics.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\BulletCollision.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\LinearMath.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\BulletSoftBody.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-collision-ode.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\ode_double.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-utils-urdf.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-utils.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\tinyxml2.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\urdfdom_sensor.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\urdfdom_model_state.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\urdfdom_model.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\urdfdom_world.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\console_bridge.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-external-odelcpsolver.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\fcl.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\ccd.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\octomap.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\octomath.lib  -lpthreads  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\fmt.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\octomap.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\octomath.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\sdformat13.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-common5-geospatial.lib  lib\gz-physics6.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-common5-graphics.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-common5.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\assimp.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\z.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-math7.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-plugin2-loader.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-plugin2.lib  D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-utils2.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
LINK: command "C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1434~1.319\bin\HostX64\x64\link.exe dartsim\CMakeFiles\UNIT_Base_TEST.dir\src\Base_TEST.cc.obj /out:bin\UNIT_Base_TEST.exe /implib:lib\UNIT_Base_TEST.lib /pdb:bin\UNIT_Base_TEST.pdb /version:0.0 /machine:x64 /INCREMENTAL:NO /subsystem:console lib\gtest.lib lib\gtest_main.lib lib\gz-physics6-dartsim-plugin.lib lib\gtest.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-collision-bullet.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\BulletDynamics.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\BulletCollision.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\LinearMath.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\BulletSoftBody.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-collision-ode.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\ode_double.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-utils-urdf.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-utils.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\tinyxml2.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\urdfdom_sensor.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\urdfdom_model_state.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\urdfdom_model.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\urdfdom_world.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\console_bridge.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\dart-external-odelcpsolver.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\fcl.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\ccd.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\octomap.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\octomath.lib -lpthreads D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\fmt.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\octomap.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\octomath.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\sdformat13.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-common5-geospatial.lib lib\gz-physics6.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-common5-graphics.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-common5.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\assimp.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\z.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-math7.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-plugin2-loader.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-plugin2.lib D:\bld\gz-physics6_1686145251501\_h_env\Library\lib\gz-utils2.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:bin\UNIT_Base_TEST.exe.manifest" failed (exit code 1120) with the following output:
Base_TEST.cc.obj : error LNK2001: unresolved external symbol "public: virtual class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const & __cdecl gz::physics::dartsim::EntityManagementFeatures::GetWorldName(class gz::physics::Identity const &)const " (?GetWorldName@EntityManagementFeatures@dartsim@physics@gz@@UEBAAEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBVIdentity@34@@Z)
Base_TEST.cc.obj : error LNK2001: unresolved external symbol "public: virtual class gz::physics::Identity __cdecl gz::physics::dartsim::EntityManagementFeatures::GetWorld(class gz::physics::Identity const &,unsigned __int64)const " (?GetWorld@EntityManagementFeatures@dartsim@physics@gz@@UEBA?AVIdentity@34@AEBV534@_K@Z)
Base_TEST.cc.obj : error LNK2001: unresolved external symbol "public: virtual class gz::physics::Identity __cdecl gz::physics::dartsim::EntityManagementFeatures::GetWorld(class gz::physics::Identity const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)const " (?GetWorld@EntityManagementFeatures@dartsim@physics@gz@@UEBA?AVIdentity@34@AEBV534@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
Base_TEST.cc.obj : error LNK2001: unresolved external symbol "public: virtual unsigned __int64 __cdecl gz::physics::dartsim::EntityManagementFeatures::GetWorldCount(class gz::physics::Identity const &)const " (?GetWorldCount@EntityManagementFeatures@dartsim@physics@gz@@UEBA_KAEBVIdentity@34@@Z)
Base_TEST.cc.obj : error LNK2001: unresolved external symbol "public: virtual unsigned __int64 __cdecl gz::physics::dartsim::EntityManagementFeatures::GetEngineIndex(class gz::physics::Identity const &)const " (?GetEngineIndex@EntityManagementFeatures@dartsim@physics@gz@@UEBA_KAEBVIdentity@34@@Z)
Base_TEST.cc.obj : error LNK2001: unresolved external symbol "public: virtual class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const & __cdecl gz::physics::dartsim::EntityManagementFeatures::GetEngineName(class gz::physics::Identity const &)const " (?GetEngineName@EntityManagementFeatures@dartsim@physics@gz@@UEBAAEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBVIdentity@34@@Z)

bin\UNIT_Base_TEST.exe : fatal error LNK1120: 56 unresolved externals

both on VS2019 and VS2022 .

@traversaro
Copy link
Contributor

both on VS2019 and VS2022 .

However, at least on VS2022 all other test link and pass fine, so I guess there is something strange in that test. In VS2019 the test COMMON_TEST_collisions_dartsim fails at runtime.

So, to proceed:

  • disable compilation of src/Base_TEST.cc
  • switch this and the downstream packages to VS2022

@traversaro traversaro closed this Jun 7, 2023
@traversaro traversaro reopened this Jun 7, 2023
@traversaro
Copy link
Contributor

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/gz-physics-feedstock/actions/runs/5203709050.

@traversaro
Copy link
Contributor

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor

In VS2019 the test COMMON_TEST_collisions_dartsim fails at runtime.

Indeed, this happens also in the CI:

2023-06-07T19:51:08.6041543Z 22/77 Test #22: COMMON_TEST_collisions_dartsim ......................................***Timeout 240.03 sec
2023-06-07T19:51:08.6112122Z [==========] Running 1 test from 1 test suite.
2023-06-07T19:51:08.6202715Z [----------] Global test environment set-up.
2023-06-07T19:51:08.6204379Z [----------] 1 test from CollisionTest/0, where TypeParam = struct CollisionFeaturesList
2023-06-07T19:51:08.6286542Z [ RUN      ] CollisionTest/0.MeshAndPlane
2023-06-07T19:51:08.6288151Z Testing plugin: gz::physics::dartsim::Plugin
2023-06-07T19:51:08.6360764Z 

@traversaro traversaro changed the title Bump to potentially fix https://github.com/conda-forge/gz-sim-feedstock/pull/9 and fix autotick bot Bump to potentially fix https://github.com/conda-forge/gz-sim-feedstock/pull/9, fix autotick bot and bump to vs2022 Jun 7, 2023
@traversaro
Copy link
Contributor

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor

In a non-deterministic way, vs2022 builds also fail with:

(base) C:\Program Files\Microsoft Visual Studio\2022\Enterprise>CALL "VC\Auxiliary\Build\vcvars64.bat" -vcvars_ver=14.34 10.0.22621.0 
**********************************************************************
** Visual Studio 2022 Developer Command Prompt v17.6.0
** Copyright (c) 2022 Microsoft Corporation
**********************************************************************
[ERROR:vcvars.bat] Toolset directory for version '14.34' was not found.
[ERROR:VsDevCmd.bat] *** VsDevCmd.bat encountered errors. Environment may be incomplete and/or incorrect. ***
[ERROR:VsDevCmd.bat] In an uninitialized command prompt, please 'set VSCMD_DEBUG=[value]' and then re-run
[ERROR:VsDevCmd.bat] vsdevcmd.bat [args] for additional details.
[ERROR:VsDevCmd.bat] Where [value] is:
[ERROR:VsDevCmd.bat]    1 : basic debug logging
[ERROR:VsDevCmd.bat]    2 : detailed debug logging
[ERROR:VsDevCmd.bat]    3 : trace level logging. Redirection of output to a file when using this level is recommended.
[ERROR:VsDevCmd.bat] Example: set VSCMD_DEBUG=3
[ERROR:VsDevCmd.bat]          vsdevcmd.bat > vsdevcmd.trace.txt 2>&1
CMake Error at D:/bld/gz-physics6_1686208106698/_build_env/Library/share/cmake-3.26/Modules/CMakeDetermineCCompiler.cmake:49 (message):
  Could not find compiler set in environment variable CC:

  cl.exe.
Call Stack (most recent call first):
  CMakeLists.txt:6 (project)

Furthermore, the test failure also occure in vs2022 with the CI. Note that the failure is:

ODE INTERNAL ERROR 1: assertion "aabbBound >= dMinIntExact && aabbBound < dMaxIntExact" failed in collide() [collision_space.cpp:460]

that apparently seems related to the simulation going unstable, see gazebosim/gz-sim#15 (comment) and related issues. For this reason, I think it is worth to just disable the test and go back to vs2019 to move forward (it is possible to use anyhow bullet instead of dart if necessary).

@traversaro
Copy link
Contributor

@conda-forge-admin, please rerender

@traversaro traversaro added the automerge Merge the PR when CI passes label Jun 8, 2023
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Jun 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@traversaro traversaro added the automerge Merge the PR when CI passes label Jun 8, 2023
@traversaro traversaro changed the title Bump to potentially fix https://github.com/conda-forge/gz-sim-feedstock/pull/9, fix autotick bot and bump to vs2022 Bump to potentially fix https://github.com/conda-forge/gz-sim-feedstock/pull/9, fix autotick bot Jun 8, 2023
@traversaro traversaro merged commit e00cc2d into conda-forge:main Jun 8, 2023
@traversaro traversaro mentioned this pull request Sep 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants