Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for hdf5 1.14.4 #147

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update hdf51144.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11350846938 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • No valid build backend found for Python recipe for package h5py using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@hmaarrfk hmaarrfk mentioned this pull request Oct 15, 2024
3 tasks
@hmaarrfk
Copy link
Contributor

@tacaswell I actually think the offending pull request was h5py/h5py#2444 which had this change h5py/h5py@6eba64b

Not really sure how better to detect numpy256 complex support at compile time.

@hmaarrfk
Copy link
Contributor

Seems like the patch is working, it is a huge hack, but you might want to merge
#146

before this to have "new h5py" on old "hdf5" pin to ease the transition for some end users.

@hmaarrfk
Copy link
Contributor

maybe something changed in 1.14.4 to make windows fail:

self = <h5py.tests.test_file.TestUnicode testMethod=test_unicode_hdf5_python_consistent>

    def test_unicode_hdf5_python_consistent(self):
        """ Unicode filenames can be used, and seen correctly from python
        """
        fname = self.mktemp(prefix=chr(0x201a))
        with File(fname, 'w') as f:
>           self.assertTrue(os.path.exists(fname))
E           AssertionError: False is not true

@hmaarrfk
Copy link
Contributor

not sure what changed in our compilation
conda-forge/hdf5-feedstock#231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants