Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDF5: 1.14.4.3 (help wanted) #229

Closed
wants to merge 1 commit into from
Closed

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Sep 2, 2024

The latest bugfix release of HDF5 1.14

Close #228

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

The latest bugfix release of HDF5 1.14
@ax3l
Copy link
Member Author

ax3l commented Sep 2, 2024

I probably will need help to redo these patches 🙏

@ax3l ax3l mentioned this pull request Sep 2, 2024
5 tasks
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Sep 3, 2024

clone both repos locally, then checkout the version 1.14.4.3, then

git am

or

git apply

can help!

Let me know if you need more guidance!

@ax3l
Copy link
Member Author

ax3l commented Sep 3, 2024

Thanks, yes I mean the patches for the configure logic.

I have to admit, I did not see the heavy patching for get HDF5 built with autotools. I will probably not have time for this in the coming two weeks (and I have barely any autotools experience). If someone wants to take over, please feel free to push here or close this PR.

@ax3l ax3l changed the title HDF5: 1.14.4.3 HDF5: 1.14.4.3 (help wanted) Sep 3, 2024
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Sep 3, 2024

it isn't so much patching for autotools, just "visual pattern matching" ;) if you have git setup locally you can give it a try.

@zklaus zklaus mentioned this pull request Sep 4, 2024
5 tasks
@astrofrog astrofrog removed their request for review September 5, 2024 10:28
@ax3l
Copy link
Member Author

ax3l commented Sep 6, 2024

Thank you so much @zklaus! closing in favor of #231 :)

@ax3l ax3l closed this Sep 6, 2024
@ax3l ax3l deleted the version-1.14.4.3 branch September 6, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HDF5 1.14.4
2 participants