Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for openssl3 (main branch = v10.1.x) #136

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update openssl3.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3464856455, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@duncanmmacleod duncanmmacleod force-pushed the rebuild-openssl3-0-1_hdfd045 branch from 2f9f790 to 498353c Compare November 29, 2022 17:46
@pkgw
Copy link
Contributor

pkgw commented Dec 3, 2022

I think the build is failing here due to a problem with the parallel build — two different processes trying to create the same static library at once. I don't have the chance to test it right now but I think that removing the --parallel option to the build will fix it.

@pkgw
Copy link
Contributor

pkgw commented Dec 5, 2022

Builds largely failed but for a different reason this time! Many complaints about htcondor-utils from the overlinking check(s) on Linux.

@pkgw
Copy link
Contributor

pkgw commented Dec 6, 2022

Ah, OK, I think that the problem here is that libcondor_utils is being built only as a static library, not shared. Still trying to figure out why; the CMake specification seems to be quite clearly intending to make it shared.

It looks like the CMake files were written for CMake 2.x, while we build
with CMake 3.x. The latter adds some new rules for expanding variables
in CMake `if()` statements that broke the behavior of the CMake files in
a non-obvious way: first a `file truncated` error relating to the same
library being built twice at once during parallel builds, then library
linking issues because `libcondor_utils` was emerging as a static
library on Linux even though it should have been shared.
@pkgw
Copy link
Contributor

pkgw commented Dec 6, 2022

I think I figured out the issue here — looks like CMake 3.1 introduced a behavior change that broke the build scripts in a hard-to-trace way.

@pkgw pkgw changed the title Rebuild for openssl3 Rebuild for openssl3 (main branch = v10.1.x) Dec 6, 2022
@pkgw
Copy link
Contributor

pkgw commented Dec 7, 2022

Straight-up compile error for macOS/OpenSSL 3:

$WORK/src/condor_io/condor_auth_ssl.cpp:307:28: error: assigning to 'unsigned long (*)(SSL_CTX *, unsigned long)' (aka 'unsigned long (*)(ssl_ctx_st *, unsigned long)') from incompatible type 'uint64_t (SSL_CTX *, uint64_t)' (aka 'unsigned long long (ssl_ctx_st *, unsigned long long)'): type mismatch at 2nd parameter ('unsigned long' vs 'uint64_t' (aka 'unsigned long long'))
         SSL_CTX_set_options_ptr = SSL_CTX_set_options;
                                   ^~~~~~~~~~~~~~~~~~~

@pkgw pkgw force-pushed the rebuild-openssl3-0-1_hdfd045 branch from b4c36fa to 9a185ed Compare December 7, 2022 01:20
@pkgw
Copy link
Contributor

pkgw commented Dec 7, 2022

All green! If anyone wants to review, I'll port the fixes to the other branches after they're finalized.

@duncanmmacleod
Copy link
Contributor

@pkgw, please give me time to review this, there was an upstream patch that I wanted to backport to fix the openssl3-on-macos issue, but I got blocked by the other build failures.

@duncanmmacleod
Copy link
Contributor

@pkgw, please give me time to review this, there was an upstream patch that I wanted to backport to fix the openssl3-on-macos issue, but I got blocked by the other build failures.

@pkgw, thanks for the work on this, it's been bugging me for a while. I have reproduced your successful builds, and compared the patches to upstream commits that implement the same fixes (see htcondor/htcondor@047de99 and htcondor/htcondor@79f1788).

I'm happy to merge this, and thanks for the offer to backport this to the other branches.

@duncanmmacleod duncanmmacleod merged commit 86d89cc into conda-forge:main Dec 13, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-openssl3-0-1_hdfd045 branch December 13, 2022 11:42
@pkgw
Copy link
Contributor

pkgw commented Dec 13, 2022

OK, I've updated the other PRs with backports that will hopefully get things working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants