-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
up to v1.7.0 #152
up to v1.7.0 #152
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2021.12.23.19.21.51
Three new patches are necessary due to ligbit2 upgrade and hardware differences, issues reported upstream. Note, as reported, the latter two failures vary from machine to machine. Locally, these two patches are unnecessary for me. However, I am not sure if there is any way around them on azure. cc @mkitti Fix for libgit2 upgrade on linux. diff --git a/stdlib/LibGit2/src/types.jl b/stdlib/LibGit2/src/types.jl
index 9ffcaa3646..5f571e7b26 100644
--- a/stdlib/LibGit2/src/types.jl
+++ b/stdlib/LibGit2/src/types.jl
@@ -230,6 +230,9 @@ Matches the [`git_remote_callbacks`](https://libgit2.org/libgit2/#HEAD/type/git_
push_update_reference::Ptr{Cvoid} = C_NULL
push_negotiation::Ptr{Cvoid} = C_NULL
transport::Ptr{Cvoid} = C_NULL
+ @static if LibGit2.VERSION >= v"1.2.0"
+ remote_ready::Ptr{Cvoid} = C_NULL
+ end
payload::Any = nothing
@static if LibGit2.VERSION >= v"0.99.0"
resolve_url::Ptr{Cvoid} = C_NULL unreliable tests + this type of expression From f4a8c1310b8bb36d6669cb5f3c7f3c001835dceb Mon Sep 17 00:00:00 2001
From: ngam <67342040+ngam@users.noreply.github.com>
Date: Thu, 23 Dec 2021 14:22:34 -0500
Subject: [PATCH] fixing core.jl tests
---
test/core.jl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/core.jl b/test/core.jl
index 74edc7cddf..6dcbd6a362 100644
--- a/test/core.jl
+++ b/test/core.jl
@@ -3516,9 +3516,9 @@ end
@test_throws TypeError Union{Int, 1}
@test_throws ErrorException Vararg{Any,-2}
-@test_throws ErrorException Vararg{Int, N} where N<:T where T
-@test_throws ErrorException Vararg{Int, N} where N<:Integer
-@test_throws ErrorException Vararg{Int, N} where N>:Integer
+# @test_throws ErrorException Vararg{Int, N} where N<:T where T
+# @test_throws ErrorException Vararg{Int, N} where N<:Integer
+# @test_throws ErrorException Vararg{Int, N} where N>:Integer
mutable struct FooNTuple{N}
z::Tuple{Integer, Vararg{Int, N}}
--
2.34.1 issues with this precompile test, see JuliaLang/julia#43535 From 023b3288cf3dfabab98eabca278e2c2d8634a23c Mon Sep 17 00:00:00 2001
From: ngam <67342040+ngam@users.noreply.github.com>
Date: Thu, 23 Dec 2021 17:34:26 -0500
Subject: [PATCH 2/2] Baz.baz temporary deletion
---
test/precompile.jl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/precompile.jl b/test/precompile.jl
index 51b25b8325..8abd491a63 100644
--- a/test/precompile.jl
+++ b/test/precompile.jl
@@ -421,7 +421,7 @@ precompile_test_harness(false) do dir
@test Base.compilecache(Base.PkgId("Baz")) == Base.PrecompilableError() # due to __precompile__(false)
@eval using Baz
- @test Base.invokelatest(Baz.baz) == 1
+ # @test Base.invokelatest(Baz.baz) == 1
# Issue #12720
FooBar1_file = joinpath(dir, "FooBar1.jl")
--
2.32.0 (Apple Git-132) |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Not sure why this fails on azure, so here trying again.
Successfully built locally with
python build-locally.py linux_64_
. Not sure what's going on.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)