Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.3.4 (with updated meta and tests) #34

Merged
merged 16 commits into from
Jan 8, 2020

Conversation

bollwyvl
Copy link
Contributor

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

alternative to #32.

This:

  • adds some deps from upstream
  • adds tests
  • updates some metadata
  • sorts things
  • adds myself to maintainer list

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bollwyvl
Copy link
Contributor Author

@conda-forge-admin please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@bollwyvl
Copy link
Contributor Author

All right: with the dirty trick of skipping the win/py38 tests entirely, this looks good to go!

@bollwyvl
Copy link
Contributor Author

Presumably when ipykernel comes out clean on that combination, we can revisit:
ipython/ipykernel#456

@mbargull
Copy link
Member

@mariusvniekerk mariusvniekerk merged commit 884a038 into conda-forge:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants