-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] - Convert to v1 + enable new archs + CUDA 12 - Manual git clone
#11
Conversation
…nda-forge-pinning 2025.01.22.17.59.35
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/recipe.yaml:
For recipe/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12916835359. Examine the logs at this URL for more detail. |
…nda-forge-pinning 2025.01.22.17.59.35
…nda-forge-pinning 2025.01.22.17.59.35
…nda-forge-pinning 2025.01.22.17.59.35
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12916938025. Examine the logs at this URL for more detail. |
…nda-forge-pinning 2025.01.22.17.59.35
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2025.01.22.17.59.35
…nda-forge-pinning 2025.01.22.17.59.35
…nda-forge-pinning 2025.01.23.01.33.17
This is increasingly looking like a rattler-build bug. Let's raise it |
Is this the original error?
We are calling out to |
Yep that's right This was the simplest reproducer we could come up with context:
name: katago
version: 1.15.3
package:
name: ${{ name|lower }}
version: ${{ version }}
source:
git: https://github.com/lightvector/KataGo.git
tag: v${{ version }}
build:
number: 0
script:
- touch hello.txt
about:
summary: GTP engine and self-play learning in Go
license: MIT
license_file: LICENSE
homepage: https://github.com/lightvector/KataGo
extra:
recipe-maintainers:
- hadim Copied from PR ( conda-forge/staged-recipes#28906 ) where this was tested |
There are two errors.
I will open tickets on pixi and rattler-build repos later. |
…nda-forge-pinning 2025.01.23.13.47.17
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12937715602. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
The current PR has disabled the git source from the recipe and temporarily switched to The good news is that |
git clone
I merged #13 that rely on |
# # use git_url, because katago needs a git repo to compile BUILD_DISTRIBUTED support; | ||
# # this cannot (or rather: should not) be patch out, or even patched at all (-> dirty tag), | ||
# # compare the exceedingly clear instructions/pleas here: | ||
# # https://github.com/lightvector/KataGo/blob/master/Compiling.md#building-for-distributed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can't you use the arhcive as part o the tag:
https://github.com/lightvector/KataGo/releases/tag/v1.15.3
that helps the bots too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because katago requires a git clone at build time. You can check the cmake patch I made at #13
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)