Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] - Convert to v1 + enable new archs + CUDA 12 - Manual git clone #11

Closed
wants to merge 57 commits into from

Conversation

hadim
Copy link
Member

@hadim hadim commented Jan 22, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@hadim hadim changed the title Convert to v1 and try windows/cuda Convert to v1 + enable new archs Jan 22, 2025
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 22, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found some lint.

Here's what I've got...

For recipe/recipe.yaml:

  • ❌ The feedstock has no .ci_support files and thus will not build any packages.

For recipe/recipe.yaml:

  • ℹ️ Jinja2 variable references are suggested to take a ${{<one space><variable name><one space>}} form. See lines [6].

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12916835359. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 22, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/recipe.yaml:

  • ℹ️ Jinja2 variable references are suggested to take a ${{<one space><variable name><one space>}} form. See lines [6].

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12916938025. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

@jakirkham
Copy link
Member

This is increasingly looking like a rattler-build bug. Let's raise it

@wolfv
Copy link
Member

wolfv commented Jan 23, 2025

Is this the original error?

Error: 
  × Failed to run git command: Git clone failed for source: Cloning into '/d/
  │ bld/src_cache/KataGo.git'...
  │ fatal: unable to access 'https://github.com/lightvector/KataGo.git/':
  │ error setting certificate file: /usr/ssl/certs/ca-bundle.crt

We are calling out to git on the system. But it is definitely possible that we are doing something wrong. If you have a test case I will be happy to look into it!

@jakirkham
Copy link
Member

Yep that's right

This was the simplest reproducer we could come up with

context:
  name: katago
  version: 1.15.3

package:
  name: ${{ name|lower }}
  version: ${{ version }}

source:
  git: https://github.com/lightvector/KataGo.git
  tag: v${{ version }}

build:
  number: 0
  script:
    - touch hello.txt

about:
  summary: GTP engine and self-play learning in Go
  license: MIT
  license_file: LICENSE
  homepage: https://github.com/lightvector/KataGo

extra:
  recipe-maintainers:
    - hadim

Copied from PR ( conda-forge/staged-recipes#28906 ) where this was tested

@hadim
Copy link
Member Author

hadim commented Jan 23, 2025

There are two errors.

  • The original one with SSL on Windows c-f CI when pixi is used as a conda install tool.
Error: 
  × Failed to run git command: Git clone failed for source: Cloning into '/d/
  │ bld/src_cache/KataGo.git'...
  │ fatal: unable to access 'https://github.com/lightvector/KataGo.git/':
  │ error setting certificate file: /usr/ssl/certs/ca-bundle.crt
  • Another one when using a git url from Windows
│ ╭─ Fetching source code
 │ │ Fetching source from git repo: https://github.com/lightvector/KataGo.git
 │ │ Fetching repository from https://github.com/lightvector/KataGo.git at refs/tags/v1.15.3 into D:\bld\src_cache\KataGo.git
 │ │ × error Command failed: `git rev-parse "refs/tags/v1.15.3"`

I will open tickets on pixi and rattler-build repos later.

@hadim hadim marked this pull request as draft January 23, 2025 20:25
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12937715602. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

@hadim hadim changed the title Convert to v1 + enable new archs + CUDA 12 **DO NOT MERGE** - Convert to v1 + enable new archs + CUDA 12 Jan 23, 2025
@hadim hadim changed the title **DO NOT MERGE** - Convert to v1 + enable new archs + CUDA 12 [DO NOT MERGE] - Convert to v1 + enable new archs + CUDA 12 Jan 23, 2025
@hadim
Copy link
Member Author

hadim commented Jan 23, 2025

The current PR has disabled the git source from the recipe and temporarily switched to git clone during the build waiting for the above issues to be resolved.


The good news is that win-64+cuda is working just fine.

@hadim hadim changed the title [DO NOT MERGE] - Convert to v1 + enable new archs + CUDA 12 [DO NOT MERGE] - Convert to v1 + enable new archs + CUDA 12 - Manual git clone Jan 26, 2025
@hadim hadim closed this Feb 6, 2025
@hadim
Copy link
Member Author

hadim commented Feb 6, 2025

I merged #13 that rely on source.url instead of source.git + a cmake patch to get rid of git. It does the job for now, waiting for conda-forge/conda-smithy#2239 to be fixed.

@hadim hadim deleted the convert branch February 6, 2025 18:26
# # use git_url, because katago needs a git repo to compile BUILD_DISTRIBUTED support;
# # this cannot (or rather: should not) be patch out, or even patched at all (-> dirty tag),
# # compare the exceedingly clear instructions/pleas here:
# # https://github.com/lightvector/KataGo/blob/master/Compiling.md#building-for-distributed
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't you use the arhcive as part o the tag:
https://github.com/lightvector/KataGo/releases/tag/v1.15.3

that helps the bots too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because katago requires a git clone at build time. You can check the cmake patch I made at #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants