Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: set MINIFORGE_HOME: C:\Miniforge #21

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Oct 3, 2024

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #20.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #20


From @jaimergp:

Hey, we are optimizing the provisioning overheads on Windows (download Miniforge, install dependencies, etc), and we will change the default installation path from C:\Miniforge to D:\Miniforge. This will reduce the installation times significantly. We are submitting this PR here because this feedstock was redefining CONDA_BLD_PATH to the C: drive. In that case, we do not want to move Miniforge to C:; we want both paths to be in the same drive! This should not create new builds, just protect against the upcoming change in conda-smithy, once rerendered.

More information at conda-forge/conda-smithy#2076

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin conda-forge-admin marked this pull request as ready for review October 3, 2024 16:58
@jaimergp jaimergp changed the title MNT: rerender MNT: set MINIFORGE_HOME: C:\Miniforge Oct 3, 2024
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@moritzwilksch
Copy link
Contributor

we still have to bump the build no right?

@jaimergp
Copy link
Member

Not really, the packages won't be uploaded if they already exist. This is not changing how the packages are built yet, only defending against the upcoming conda-smithy release. You can merge with a [ci skip] commit too and that would be enough.

@jaimergp
Copy link
Member

10 days have passed to I'm merging this with [ci skip] to unblock conda-forge/conda-smithy#2076. Thanks!

@jaimergp jaimergp merged commit 751f8e2 into conda-forge:main Oct 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin, please rerender
4 participants