Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #12

Merged
merged 10 commits into from
May 16, 2020
Merged

Windows support #12

merged 10 commits into from
May 16, 2020

Conversation

birdsarah
Copy link
Member

Fixes #2

Checklist:

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

I'm not an expert at conda recipes, but this looks relatively easy now cmake support is available and I'd like to be able use the package on windows.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@xhochy
Copy link
Member

xhochy commented May 16, 2020

@birdsarah Don't manually touch the files in .ci_support. They are auto-generated you can either update them locally using conda smithy rerender or kindly ask our bot to do this:

@conda-forge-admin please rerender

conda-forge-linter and others added 2 commits May 16, 2020 10:15
@xhochy xhochy merged commit 98a4ed6 into conda-forge:master May 16, 2020
@xhochy
Copy link
Member

xhochy commented May 16, 2020

Thanks @birdsarah!

@birdsarah
Copy link
Member Author

@birdsarah Don't manually touch the files in .ci_support. They are auto-generated you can either update them locally using conda smithy rerender or kindly ask our bot to do this.

@xhochy - sorry about that i hadn't figured out how to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getting Error: Package missing in current win-64 channels
3 participants