rely on run-exports, and properly disable iconv #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
requested review from
jakirkham,
mingwandroid and
ocefpaf
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…da-forge-pinning 2021.01.15.03.03.28
|
Am I deeply confused? If we want to rely on run exports then we need the packages in host but not run. This pr does the opposite. |
|
no, it only has a host section (looks confusing bc the way gitub renders the diff). |
Zaharid
added a commit
to NNPDF/nnpdf
that referenced
this pull request
Mar 5, 2021
If I try to set up a clean environment on linux I get essentially this error: conda/conda#8838 when trying to import NNPDF, which as said on the issue gets solved if one installs libiconv manually. Indeed checking libarchive with ldd I see that it is asking for libiconv and not finding it. It seems there is some amount of dancing around of dancing around in the conda forge channel with it being added conda-forge/libarchive-feedstock#36 and then removed conda-forge/libarchive-feedstock#59 and seems that that somehow can result in an incompatible environment. Pull to the latest version (and be stricter with pinning in hopes that resolves the problem.
Zaharid
added a commit
to NNPDF/nnpdf
that referenced
this pull request
Mar 10, 2021
* Fix version of libarchive If I try to set up a clean environment on linux I get essentially this error: conda/conda#8838 when trying to import NNPDF, which as said on the issue gets solved if one installs libiconv manually. Indeed checking libarchive with ldd I see that it is asking for libiconv and not finding it. It seems there is some amount of dancing around of dancing around in the conda forge channel with it being added conda-forge/libarchive-feedstock#36 and then removed conda-forge/libarchive-feedstock#59 and seems that that somehow can result in an incompatible environment. Pin the version to one that works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep running into issues with libiconv with mamba and I think libarchive accidentally links to host libiconv on linux ...
https://github.com/fastai/fastconda/runs/1706271326?check_suite_focus=true
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)