Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin down libhwloc using run_exports #18

Merged
merged 3 commits into from
May 9, 2019
Merged

Conversation

stain
Copy link
Contributor

@stain stain commented Feb 15, 2019

See discussion in bioconda/bioconda-recipes#13523 (comment)

max_pin='x.x' should hopefully do it - it is a bit aggressive for 1.x series as version 1.11.9 has libhwloc.so.5 (consistent since perhaps 1.4) - meanwhile 2.0.2 is already at libhwloc.so.15 so better play safe.

BTW, this recipe might need a folder split for 1.11 (now "ultra-stable") and 2.0 to add the later versions 1.11.10, 1.11.11 and/or 1.11.12 as well as 2.0.3 hinted at in #17.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

See discussion in bioconda/bioconda-recipes#13523 (comment) 

`max_pin='x.x'` should hopefully do it - it is a bit aggressive for `1.x` series as version `1.11.9` has `libhwloc.so.5` (consistent since perhaps `1.4`) - meanwhile `2.0.2` is already at `libhwloc.so.15` so better play safe.

BTW, this recipe might need a folder split for [1.11](https://www.open-mpi.org/software/hwloc/v1.11/) (now "ultra-stable") and [2.0](https://www.open-mpi.org/software/hwloc/v2.0/) to add the later versions `1.11.10`, `1.11.11` and/or `1.11.12` as well as `2.0.3` hinted at in conda-forge#17.

As libwloc
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@stain stain changed the title Pin down libwloc using run_exports Pin down libhwloc using run_exports Feb 15, 2019
@stain
Copy link
Contributor Author

stain commented Feb 15, 2019

Actually version 2.0.0 in conda has libhwloc.so.12, so we would need even tighter pinning x.x.x for 2.x and looser for 1.x. I'll make a separate PR to re-add 1.x for its latest updates with looser pinning.

.. as in `2.0` series the `.so` number has already changed from `libhwloc.so.12` (2.0.0) to `libhwloc.so.15` (2.0.2)
@isuruf isuruf merged commit 90b662a into conda-forge:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants