Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backward install #14

Merged
merged 6 commits into from
Dec 2, 2021
Merged

Fix backward install #14

merged 6 commits into from
Dec 2, 2021

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Dec 1, 2021 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

See conda-forge/libsdformat-feedstock#52

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer
Copy link
Contributor Author

This is ready for review @conda-forge/libignition-tools

@Tobias-Fischer
Copy link
Contributor Author

Have locally confirmed that this fixes conda-forge/libsdformat-feedstock#52

@Tobias-Fischer Tobias-Fischer mentioned this pull request Dec 2, 2021
Closed
3 tasks
@traversaro
Copy link
Contributor

I am not sure why this is necessary, but as long the path is relocated correctly, it should work fine.

@traversaro traversaro merged commit 04366bb into conda-forge:master Dec 2, 2021
@Tobias-Fischer Tobias-Fischer deleted the fix-backward-install branch December 2, 2021 18:54
@traversaro traversaro mentioned this pull request Dec 4, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero

@seanyen seanyen Awaiting requested review from seanyen

@wolfv wolfv Awaiting requested review from wolfv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tobias-Fischer @conda-forge-linter @traversaro