Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple ref to ocdebug #112

Closed
wants to merge 1 commit into from
Closed

Fix multiple ref to ocdebug #112

wants to merge 1 commit into from

Conversation

jschueller
Copy link
Contributor

@jschueller jschueller commented Dec 11, 2020 •
edited
Loading

build fails on osx,
I applied just the fix suggested from Unidata/netcdf-c#1725
this seems actually fixed after Unidata/netcdf-c#1732, but other patches may conflict

@conda-forge-admin please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

3 similar comments
@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

ocefpaf
ocefpaf approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@ocefpaf ocefpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd love for @dopplershift to take a look too before we merge.

@jschueller jschueller closed this Dec 11, 2020
@dopplershift
Copy link
Member

I'm confused. Is this needed still or not?

@jschueller
Copy link
Contributor Author

turns out its only needed on rerender, what I really needed is #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocefpaf ocefpaf ocefpaf approved these changes

@beckermr beckermr Awaiting requested review from beckermr

@groutr groutr Awaiting requested review from groutr

@kmuehlbauer kmuehlbauer Awaiting requested review from kmuehlbauer

@mingwandroid mingwandroid Awaiting requested review from mingwandroid

@msarahan msarahan Awaiting requested review from msarahan

@xylar xylar Awaiting requested review from xylar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jschueller @conda-forge-linter @dopplershift @ocefpaf