Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug #64

Closed
wants to merge 4 commits into from
Closed

Remove debug #64

wants to merge 4 commits into from

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Nov 26, 2018

Addresses #58 (comment)

Ping @isuruf

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 26, 2018

@kmuehlbauer regarding the remote tests, I tested the 4.6.2 version and only

ncdump -h "https://data.nodc.noaa.gov/thredds/dodsC/ioos/sccoos/scripps_pier/scripps_pier-2016.nc"

seems to be failing (but it passes with the previous version). However, none of them passes at build time, not sure if that is related to the curl version being pulled of the build env :-/

recipe/build.sh Outdated
@@ -69,7 +68,6 @@ cmake -DCMAKE_INSTALL_PREFIX=${PREFIX} \
-DENABLE_DOXYGEN=OFF \
-DENABLE_LOGGING=ON \
-DCMAKE_C_FLAGS_RELEASE=${CFLAGS} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for the removal of these two?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmuehlbauer
Copy link
Contributor

@ocefpaf We have this conda-build pin to 3.16.2 in build.sh. This is not connected to the failure we see? I'm struggling to get a grip here.

@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 28, 2018

@ocefpaf We have this conda-build pin to 3.16.2 in build.sh.

We need to investigate this to avoid the workaround but as you notice we ate hitting another issue here :-(

This is not connected to the failure we see? I'm struggling to get a grip here.

Same here, no clue... (I'm in a bad time with the day job, reports season! So I won't be able to follow up on this PR, sorry.)

@jschueller
Copy link
Contributor

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@ocefpaf ocefpaf closed this Feb 1, 2019
@ocefpaf ocefpaf deleted the remove_debug branch February 1, 2019 11:53
@ocefpaf ocefpaf mentioned this pull request Feb 1, 2019
@manishsoni0291
Copy link

Please tell me if somebody find a solution how to do it

@kmuehlbauer
Copy link
Contributor

@manishsoni0291 This was resolved with #78

If this is still a problem please open a new issue with enough information to reproduce...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants