Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compilation with libccd #22

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Mar 17, 2024

Apparently if libccd is not used, some checks (for example cone-cone and cylinder-cylinder) are silently not done. For consistency with other builds of libode, for example Debian (), let's enable the libccd dependency.

To ensure that the compilation works fine, I also had to backport https://bitbucket.org/odedevs/ode/commits/89b3286467985b1b04b78dc1ad6642830d12ba58 , otherwise the compilation of 0.16.2 with CMake and trying to use the conda-forge libccd was not working fine.

To ensure that find_package(ODE) continue to work, I added to the tests a check using https://github.com/ami-iit/cmake-package-check?tab=readme-ov-file#use-to-test-in-conda-recipes-if-a-cmake-package-is-installed .

Fix conda-forge/dartsim-feedstock#39 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro traversaro requested a review from repagh as a code owner March 17, 2024 18:28
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cone/Cone and Cylinder/Cylinder collisions are not working when using ODECollisionDetector
1 participant