switch extensions of static libs on windows

[h-vetinari]

Another fallout from #128, which changed the static libs to depend on the shared ones according to conda-forge/conda-forge.github.io#1809.

This needed an adaptation of the import library names (since they share the .lib suffix with the static ones); so far so good, all that is saved in the CMake metadata. However, CMake prefers its own custom FindProtobuf despite having package metadata created by itself, and then ends up not finding the adapted import libs. 🤦

Undo this to stop the bleeding. Switch the extension of the import library to use the default ".lib", see this comment

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[traversaro]

Thanks a lot @h-vetinari ! Just a curiosity, I guess that you considered renaming the static libraries to protobuf-static.lib? If you did not, I guess probably this is not possible, but I do not know why.

[h-vetinari]

I guess that you considered renaming the static libraries to protobuf-static.lib? If you did not, I guess probably this is not possible, but I do not know why.

That would just create the same problem for any user of the libprotobuf-static output. 🤷

Together with:

• windows using the same extensions for different things
• CMake not respecting the package metadata

I don't see how else to fix this TBH...

[traversaro]

I guess that you considered renaming the static libraries to protobuf-static.lib? If you did not, I guess probably this is not possible, but I do not know why.

That would just create the same problem for any user of the libprotobuf-static output. 🤷

In which way? If I understood correctly, after #128 libprotobuf-static would depend on libprotobuf, so find_package(Protobuf REQUIRED) would be happy and find the shared version. Probably what would be broken is the use of Protobuf_USE_STATIC_LIBS, that however by default is OFF, right? Anyhow, this PR is definetely the solution with less problems.

[h-vetinari]

In which way? If I understood correctly, after #128 libprotobuf-static would depend on libprotobuf, so find_package(Protobuf REQUIRED) would be happy and find the shared version. Probably what would be broken is the use of Protobuf_USE_STATIC_LIBS, that however by default is OFF, right? Anyhow, this PR is definetely the solution with less problems.

Fair enough, thanks for walking me through that...