Fix static libs on windows #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's CMAKE_{SHARED,STATIC,IMPORT}_LIBRARY_SUFFIX
and there's set_target_properties(... IMPORT_SUFFIX ...),
but no STATIC_SUFFIX. 🤷
h-vetinari
requested review from
dopplershift,
hajapy,
jakirkham,
ocefpaf,
wesm,
xhochy and
xylar
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
3 tasks
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/libprotobuf-feedstock/actions/runs/3111800337. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's
CMAKE_{SHARED,STATIC,IMPORT}_LIBRARY_SUFFIXand there's
set_target_properties(... IMPORT_SUFFIX ...),but no
STATIC_SUFFIX. 🤷