Use cmake #47
Merged
Use cmake #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
requested review from
dopplershift,
hajapy,
jakirkham,
jjhelmus,
ocefpaf,
wesm and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
jjhelmus
approved these changes
Feb 24, 2020
|
LGTM. Removing the static library should be fine. If downstream packages require it, it can be added back. |
|
The switch to cmake resulted in different dynamic libraries being created, see #48. I've moved the new packages to |
|
Also, please keep the static library. I need it for linking against a go module. |
Would it be OK to have it in a separate libprotobuf-static? |
jjhelmus
added a commit
to jjhelmus/libprotobuf-feedstock
that referenced
this pull request
May 22, 2020
This was referenced May 22, 2020
jjhelmus
added a commit
that referenced
this pull request
May 26, 2020
Revert #47 and update to 3.12.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @xhochy
For the time being I have also removed the static library build. Not sure if that is going to break everything :) do we need the static lib?
For me the main reason to do this is that CMake installs the files necessary to
find_packageprotobuf from other projects.