Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt osx build #8

Merged
merged 10 commits into from
May 28, 2020
Merged

Attempt osx build #8

merged 10 commits into from
May 28, 2020

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented May 28, 2020

Checklist

@Tobias-Fischer Tobias-Fischer requested review from j-rivero, seanyen and a team as code owners May 28, 2020 01:02
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-linter and others added 3 commits May 28, 2020 01:04
@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer
Copy link
Contributor Author

Hi @seanyen @j-rivero
This PR adds osx support. The Windows build fails for unrelated reasons; it would be great if you could check why that is.
It would be great if this PR could be merged so we can get Gazebo on osx.

Many thanks!

@Tobias-Fischer
Copy link
Contributor Author

Hacked the Windows build in 7cc4d49

Seems like Ruby is missing in newer build setups.

It would be great if you could merge this PR :)

@wolfv
Copy link
Member

wolfv commented May 28, 2020

@Tobias-Fischer if it's Ruby that's missing, wouldn't it be better to install it with conda?

@wolfv
Copy link
Member

wolfv commented May 28, 2020

ok apparently there is no ruby package for win...

@Tobias-Fischer
Copy link
Contributor Author

Tobias-Fischer commented May 28, 2020

Yeah .. not sure why Ruby was removed from https://github.com/conda-forge/conda-forge-ci-setup-feedstock - ideally we would want to have it back. Let's see whether this hack will allow us to at least merge this for now so we can do further stuff on OSX.

@Tobias-Fischer
Copy link
Contributor Author

The hack does not seem to work: "Distribution D:\bld\win-64\libsdformat-9.1.0-h7dee32a_3.tar.bz2 is new for conda-forge, but no upload is taking place because the BINSTAR_TOKEN is missing."

Will wait for https://github.com/conda-forge/ruby-feedstock/issues/38 I guess ..

@seanyen
Copy link
Contributor

seanyen commented May 28, 2020

@Tobias-Fischer I think you can skip the Windows build for this release. The Ruby thing looks little more complicated and I anticipated it might take longer runway to tackle it. I don't want this to be a blocker Gazebo on MacOS enablement. :)

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer Tobias-Fischer mentioned this pull request May 28, 2020
@seanyen
Copy link
Contributor

seanyen commented May 28, 2020

LGTM.

@seanyen seanyen merged commit ec96a99 into conda-forge:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants