Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows + CUDA #6

Merged
merged 21 commits into from
Dec 5, 2023
Merged

Conversation

sodre
Copy link
Member

@sodre sodre commented Dec 5, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@sodre sodre changed the title Start work on windows builds Add Windows + CUDA Dec 5, 2023
@sodre
Copy link
Member Author

sodre commented Dec 5, 2023

@conda-forge-admin, please rerender

@sodre sodre marked this pull request as ready for review December 5, 2023 08:21
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/llama.cpp-feedstock/actions/runs/7097997778.

Copy link
Member Author

@sodre sodre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document that cuda-cudart_win-64 package is not populating automatically

Comment on lines +59 to +60
- cuda-cudart {{ cuda_compiler_version }} # [(cuda_compiler_version or "").startswith("12")]
- cuda-cudart_{{ target_platform }} {{ cuda_compiler_version }} # [(cuda_compiler_version or "").startswith("12") and win]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something Is wrong with the Windows dependencies. Unless I add the line above I get the following error on Windows

  ERROR (llama.cpp,bin/main.exe): Needed DSO Library/bin/cudart64_12.dll found in ['cuda-cudart_win-64']
  ERROR (llama.cpp,bin/main.exe): .. but ['cuda-cudart_win-64'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is due to upstream issue ( conda-forge/cuda-cudart-feedstock#13 (comment) )

We just merged a fix ( conda-forge/cuda-cudart-feedstock#14 ). So this should be resolved with the new packages

Think we can drop this then

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised issue ( #16 ) to track

@sodre sodre added the automerge Merge the PR when CI passes label Dec 5, 2023
@github-actions github-actions bot merged commit 29bd539 into conda-forge:main Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@sodre sodre deleted the chore/win-cuda branch December 5, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants