-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove overconstraint of numpy dependency #28
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.12.15.19.46.12
This solve the problem that constraining the numpy version results in an old build of manifpy installed, see ami-iit/bipedal-locomotion-framework#578 (comment) . This is particular problematic as downstream python bindings that use manifpy need to be compiled with the same major version of manifpy, and this constraint is not modeled by conda-forge (see conda-forge/pybind11-feedstock#77 and the issues and PR that link it). fyi @GiulioRomualdi |
(Unrelated: we need to propagate this also to the blf feedstock @GiulioRomualdi) |
Nevermind, numpy is already just a runtime dependency there. |
That's wonderful! Thank you @traversaro! |
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
Merging as the ppc64le problem was just a flake, and we can anyhow fix this later. |
manifpy
interacts with numpy only via pybind11, however as one can read in https://pybind11.readthedocs.io/en/stable/advanced/pycpp/numpy.html :That means that we do not need to declare numpy as an host dependency, and the numpy dependency at runtime is without any particular constraint.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)