Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overconstraint of numpy dependency #28

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Dec 16, 2022

manifpy interacts with numpy only via pybind11, however as one can read in https://pybind11.readthedocs.io/en/stable/advanced/pycpp/numpy.html :

Note that pybind11/numpy.h does not depend on the NumPy headers, and thus can be used without declaring a build-time dependency on NumPy; NumPy>=1.7.0 is a runtime dependency.

That means that we do not need to declare numpy as an host dependency, and the numpy dependency at runtime is without any particular constraint.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

This solve the problem that constraining the numpy version results in an old build of manifpy installed, see ami-iit/bipedal-locomotion-framework#578 (comment) . This is particular problematic as downstream python bindings that use manifpy need to be compiled with the same major version of manifpy, and this constraint is not modeled by conda-forge (see conda-forge/pybind11-feedstock#77 and the issues and PR that link it).

fyi @GiulioRomualdi

@traversaro traversaro added the automerge Merge the PR when CI passes label Dec 16, 2022
@traversaro
Copy link
Contributor Author

(Unrelated: we need to propagate this also to the blf feedstock @GiulioRomualdi)

@traversaro
Copy link
Contributor Author

(Unrelated: we need to propagate this also to the blf feedstock @GiulioRomualdi)

Nevermind, numpy is already just a runtime dependency there.

@GiulioRomualdi
Copy link

That's wonderful! Thank you @traversaro!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Dec 16, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@traversaro traversaro added the automerge Merge the PR when CI passes label Dec 16, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@traversaro
Copy link
Contributor Author

Merging as the ppc64le problem was just a flake, and we can anyhow fix this later.

@traversaro traversaro merged commit 861b9df into conda-forge:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants