ARM OSX Migrator #62

regro-cf-autotick-bot · 2022-05-27T04:25:05Z

This feedstock is being rebuilt as part of the ARM OSX migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2394393899, please use this URL for debugging.}

…nda-forge-pinning 2022.05.25.19.48.06

conda-forge-linter · 2022-05-27T04:25:09Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hoechenberger · 2022-05-27T07:38:16Z

It appears some of the jobs failed because of download errors. Will try to restart CI.

@conda-forge-admin, please restart ci

hoechenberger · 2022-05-27T07:59:54Z

Ok, all CI failures we're now seeing are real.

The failing Windows builds seem to be caused by an issue with the conda-forge build infrastructure itself?

2022-05-27T07:53:18.8724549Z INFO:conda_build.build:Packaging mayavi
2022-05-27T07:53:18.8725564Z Packaging mayavi
2022-05-27T07:53:21.0749275Z INFO:conda_build.build:Packaging mayavi-4.7.4-py310h11128ef_1
2022-05-27T07:53:21.0751277Z Packaging mayavi-4.7.4-py310h11128ef_1
2022-05-27T07:53:33.8679556Z compiling .pyc files...
2022-05-27T07:53:36.2368791Z Traceback (most recent call last):
2022-05-27T07:53:36.2369899Z number of files: 980
2022-05-27T07:53:36.2370402Z   File "C:\Miniconda\Scripts\conda-mambabuild-script.py", line 9, in <module>
2022-05-27T07:53:36.2370913Z     sys.exit(main())
2022-05-27T07:53:36.2371343Z   File "C:\Miniconda\lib\site-packages\boa\cli\mambabuild.py", line 239, in main
2022-05-27T07:53:36.2372152Z     call_conda_build(action, config)
2022-05-27T07:53:36.2372735Z   File "C:\Miniconda\lib\site-packages\boa\cli\mambabuild.py", line 211, in call_conda_build
2022-05-27T07:53:36.2373292Z     result = api.build(
2022-05-27T07:53:36.2373781Z   File "C:\Miniconda\lib\site-packages\conda_build\api.py", line 186, in build
2022-05-27T07:53:36.2375515Z     return build_tree(
2022-05-27T07:53:36.2376335Z   File "C:\Miniconda\lib\site-packages\conda_build\build.py", line 3088, in build_tree
2022-05-27T07:53:36.2377125Z     packages_from_this = build(metadata, stats,
2022-05-27T07:53:36.2378876Z   File "C:\Miniconda\lib\site-packages\conda_build\build.py", line 2371, in build
2022-05-27T07:53:36.2380535Z     newly_built_packages = bundlers[pkg_type](output_d, m, env, stats)
2022-05-27T07:53:36.2381181Z   File "C:\Miniconda\lib\site-packages\conda_build\build.py", line 1664, in bundle_conda
2022-05-27T07:53:36.2382220Z     files = post_process_files(metadata, initial_files)
2022-05-27T07:53:36.2383159Z   File "C:\Miniconda\lib\site-packages\conda_build\build.py", line 1510, in post_process_files
2022-05-27T07:53:36.2384247Z     post_build(m, new_files, build_python=python)
2022-05-27T07:53:36.2385471Z   File "C:\Miniconda\lib\site-packages\conda_build\post.py", line 1318, in post_build
2022-05-27T07:53:36.2388008Z     check_overlinking(m, files, host_prefix)
2022-05-27T07:53:36.2388629Z   File "C:\Miniconda\lib\site-packages\conda_build\post.py", line 1224, in check_overlinking
2022-05-27T07:53:36.2389757Z     return check_overlinking_impl(m.get_value('package/name'),
2022-05-27T07:53:36.2390648Z   File "C:\Miniconda\lib\site-packages\conda_build\post.py", line 1048, in check_overlinking_impl
2022-05-27T07:53:36.2391328Z     packages = dists_from_names(requirements_run, run_prefix)
2022-05-27T07:53:36.2391923Z   File "C:\Miniconda\lib\site-packages\conda_build\post.py", line 639, in dists_from_names
2022-05-27T07:53:36.2392480Z     pkgs = linked_data_no_multichannels(prefix)
2022-05-27T07:53:36.2393404Z   File "C:\Miniconda\lib\site-packages\conda_build\utils.py", line 2084, in linked_data_no_multichannels
2022-05-27T07:53:36.2393996Z     from conda.common.compat import itervalues
2022-05-27T07:53:36.2397396Z ImportError: cannot import name 'itervalues' from 'conda.common.compat' (C:\Miniconda\lib\site-packages\conda\common\compat.py)
2022-05-27T07:53:49.1409691Z ##[error]Cmd.exe exited with code '1'.
2022-05-27T07:53:49.5136124Z ##[section]Finishing: Build recipe

Whereas on osx_arm64, we seem to be having an issue with VTK (?):

2022-05-27T07:52:55.6023530Z   running bdist_wheel
2022-05-27T07:52:55.6125190Z   running build
2022-05-27T07:52:55.6227150Z   Traceback (most recent call last):
2022-05-27T07:52:55.6330080Z     File "<string>", line 2, in <module>
2022-05-27T07:52:55.6431410Z     File "<pip-setuptools-caller>", line 34, in <module>
2022-05-27T07:52:55.6534500Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/work/setup.py", line 411, in <module>
2022-05-27T07:52:55.6636800Z       setup(
2022-05-27T07:52:55.6753690Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/_build_env/venv/lib/python3.8/site-packages/numpy/distutils/core.py", line 169, in setup
2022-05-27T07:52:55.6885720Z       return old_setup(**new_attr)
2022-05-27T07:52:55.6987950Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/_build_env/venv/lib/python3.8/site-packages/setuptools/__init__.py", line 87, in setup
2022-05-27T07:52:55.7090770Z       return distutils.core.setup(**attrs)
2022-05-27T07:52:55.7121860Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/_build_env/venv/lib/python3.8/site-packages/setuptools/_distutils/core.py", line 148, in setup
2022-05-27T07:52:55.7223760Z       return run_commands(dist)
2022-05-27T07:52:55.7328500Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/_build_env/venv/lib/python3.8/site-packages/setuptools/_distutils/core.py", line 163, in run_commands
2022-05-27T07:52:55.7558840Z       dist.run_commands()
2022-05-27T07:52:55.7676550Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/_build_env/venv/lib/python3.8/site-packages/setuptools/_distutils/dist.py", line 967, in run_commands
2022-05-27T07:52:55.7780920Z       self.run_command(cmd)
2022-05-27T07:52:55.7884030Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/_build_env/venv/lib/python3.8/site-packages/setuptools/dist.py", line 1229, in run_command
2022-05-27T07:52:55.7987700Z       super().run_command(command)
2022-05-27T07:52:55.8090890Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/_build_env/venv/lib/python3.8/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
2022-05-27T07:52:55.8193060Z       cmd_obj.run()
2022-05-27T07:52:55.8284580Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/_build_env/venv/lib/python3.8/site-packages/wheel/bdist_wheel.py", line 299, in run
2022-05-27T07:52:55.8316270Z       self.run_command('build')
2022-05-27T07:52:55.8344550Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/_build_env/venv/lib/python3.8/site-packages/setuptools/_distutils/cmd.py", line 313, in run_command
2022-05-27T07:52:55.8446750Z       self.distribution.run_command(command)
2022-05-27T07:52:55.8553700Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/_build_env/venv/lib/python3.8/site-packages/setuptools/dist.py", line 1229, in run_command
2022-05-27T07:52:55.8554990Z       super().run_command(command)
2022-05-27T07:52:55.8657800Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/_build_env/venv/lib/python3.8/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
2022-05-27T07:52:55.8760050Z       cmd_obj.run()
2022-05-27T07:52:55.8844970Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/work/setup.py", line 268, in run
2022-05-27T07:52:55.8947090Z       build_tvtk_classes_zip()
2022-05-27T07:52:55.9050130Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/work/setup.py", line 254, in build_tvtk_classes_zip
2022-05-27T07:52:55.9152730Z       gen_tvtk_classes_zip()
2022-05-27T07:52:55.9256120Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/work/tvtk/setup.py", line 82, in gen_tvtk_classes_zip
2022-05-27T07:52:55.9303840Z       from tvtk.code_gen import TVTKGenerator
2022-05-27T07:52:55.9365990Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/work/tvtk/code_gen.py", line 30, in <module>
2022-05-27T07:52:55.9468180Z       from .common import get_tvtk_name, camel2enthought
2022-05-27T07:52:55.9571620Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/work/tvtk/common.py", line 10, in <module>
2022-05-27T07:52:55.9673800Z       import vtk
2022-05-27T07:52:55.9776790Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/_build_env/venv/lib/python3.8/site-packages/vtk.py", line 31, in <module>
2022-05-27T07:52:55.9843420Z       all_m = importlib.import_module('vtkmodules.all')
2022-05-27T07:52:55.9946310Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/_build_env/lib/python3.8/importlib/__init__.py", line 127, in import_module
2022-05-27T07:52:56.0027440Z       return _bootstrap._gcd_import(name[level:], package, level)
2022-05-27T07:52:56.0130660Z     File "/Users/runner/miniforge3/conda-bld/mayavi_1653637473717/_build_env/venv/lib/python3.8/site-packages/vtkmodules/all.py", line 7, in <module>
2022-05-27T07:52:56.0232810Z       from .vtkCommonCore import *
2022-05-27T07:52:56.0336740Z   ModuleNotFoundError: No module named 'vtkmodules.vtkCommonCore'
2022-05-27T07:52:56.0427560Z   error: subprocess-exited-with-error
2022-05-27T07:52:56.0522350Z   
2022-05-27T07:52:56.0589930Z   × python setup.py bdist_wheel did not run successfully.
2022-05-27T07:52:56.0663720Z   │ exit code: 1
2022-05-27T07:52:56.0724120Z   ╰─> See above for output.

hoechenberger · 2022-05-27T08:13:35Z

The failing Windows builds seem to be caused by an issue with the conda-forge build infrastructure itself?

This is being tracked at conda-forge/conda-build-feedstock#176 and conda-forge/conda-forge.github.io#1762

hoechenberger · 2022-05-27T08:18:59Z

I just ran locally:

❯ CONDA_SUBDIR=osx-arm64 mamba create -n test vtk
❯ mamba activate test
❯ python -c 'import vtkmodules.vtkCommonCore'

and it works without problems…

larsoner · 2022-05-27T14:40:24Z

vtk.py fiddles with sys.modules, could that be the issue here?

https://gitlab.kitware.com/vtk/vtk/-/blob/master/Wrapping/Python/vtk.py#L42

The failure happens before they do anything to sys.modules so I think it's unlikely.

hoechenberger · 2022-05-27T14:43:13Z

You sure? My understanding of their tooling is that by the time you can import anything from vtk, these modifications have been taking place already. Might be mistaken though, but this was what I figured when I briefly checked earlier today

recipe/meta.yaml

larsoner · 2022-05-27T14:45:20Z

The failure is in the call to all_m = importlib.import_module('vtkmodules') which precedes them doing sys.modules[__name__] = all_m

hoechenberger · 2022-05-27T14:46:12Z

At okay, thanks! Fingers crossed. TTY in a bit!

larsoner · 2022-05-27T15:00:55Z

ARM succeeded, so now we just wait for conda/conda-build#4482, CDN update, restart CIs, then it should auto-merge!

github-actions · 2022-05-27T15:11:06Z

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!

hoechenberger · 2022-05-27T16:23:20Z

ARM succeeded, so now we just wait for conda/conda-build#4482, CDN update, restart CIs, then it should auto-merge!

I still don't understand why it's only now that vtk is needed as a build dependency 🤔 Because we're cross-building?

larsoner · 2022-05-27T16:46:57Z

Because we're cross-building?

Yes I think so -- I think that's what the selectors are for

hoechenberger · 2022-05-27T16:49:57Z

Nice job, @larsoner!!!

regro-cf-autotick-bot added 2 commits May 27, 2022 04:24

migration: OSXArm

8455417

MNT: Re-rendered with conda-build 3.21.8, conda-smithy 3.19.0, and co…

869035d

…nda-forge-pinning 2022.05.25.19.48.06

regro-cf-autotick-bot requested review from Cadair, dfroger, grlee77, larsoner and msarahan as code owners May 27, 2022 04:25

conda-forge-linter closed this May 27, 2022

conda-forge-linter reopened this May 27, 2022

This comment was marked as resolved.

Sign in to view

FIX: Add

a59130d

larsoner reviewed May 27, 2022

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

larsoner added the automerge Merge the PR when CI passes label May 27, 2022

larsoner mentioned this pull request May 27, 2022

Build on Apple Silicon mne-tools/mne-installers#48

Closed

15 tasks

github-actions bot merged commit 54ae18a into conda-forge:main May 27, 2022

larsoner mentioned this pull request May 27, 2022

Fix for conda 4.13.0 Python 2.7 removal conda/conda-build#4482

Merged

regro-cf-autotick-bot deleted the bot-pr_arm_osx_h00fd05 branch May 27, 2022 16:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARM OSX Migrator #62

ARM OSX Migrator #62

regro-cf-autotick-bot commented May 27, 2022

conda-forge-linter commented May 27, 2022

hoechenberger commented May 27, 2022

hoechenberger commented May 27, 2022

hoechenberger commented May 27, 2022 •

edited

Loading

hoechenberger commented May 27, 2022

This comment was marked as resolved.

larsoner commented May 27, 2022

hoechenberger commented May 27, 2022

larsoner commented May 27, 2022 •

edited

Loading

hoechenberger commented May 27, 2022 •

edited

Loading

larsoner commented May 27, 2022

github-actions bot commented May 27, 2022 •

edited

Loading

hoechenberger commented May 27, 2022 •

edited

Loading

larsoner commented May 27, 2022

hoechenberger commented May 27, 2022

ARM OSX Migrator #62

ARM OSX Migrator #62

Conversation

regro-cf-autotick-bot commented May 27, 2022

conda-forge-linter commented May 27, 2022

hoechenberger commented May 27, 2022

hoechenberger commented May 27, 2022

hoechenberger commented May 27, 2022 • edited Loading

hoechenberger commented May 27, 2022

This comment was marked as resolved.

larsoner commented May 27, 2022

hoechenberger commented May 27, 2022

larsoner commented May 27, 2022 • edited Loading

hoechenberger commented May 27, 2022 • edited Loading

larsoner commented May 27, 2022

github-actions bot commented May 27, 2022 • edited Loading

hoechenberger commented May 27, 2022 • edited Loading

larsoner commented May 27, 2022

hoechenberger commented May 27, 2022

hoechenberger commented May 27, 2022 •

edited

Loading

larsoner commented May 27, 2022 •

edited

Loading

hoechenberger commented May 27, 2022 •

edited

Loading

github-actions bot commented May 27, 2022 •

edited

Loading

hoechenberger commented May 27, 2022 •

edited

Loading