Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpi4py v3.1.5 #65

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • cython

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6404663198, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dalcinl dalcinl self-assigned this Oct 4, 2023
@dalcinl
Copy link
Contributor

dalcinl commented Oct 4, 2023

@minrk @isuruf Folks, in this update, I'm adding support for Intel MPI (Linux and Windows). However, I believe the Intel MPI support in conda-forge is still a bit precarious.

  • We have the two packages impi-devel and impi_rt, but these packages are not proper MPI providers, in the sense that they are coming almost verbatim from the Intel channel, and there is no proper dependency on the mpi metapackage.
  • We do not have impi-mpi{cc|cxx|fort} packages to pull in the compilers.

@dalcinl
Copy link
Contributor

dalcinl commented Oct 4, 2023

On top of my previous comments, it seems that the compiler wrappers are not usable as they are, because they do not use the compiler commands from the compiler package.

@dalcinl
Copy link
Contributor

dalcinl commented Oct 4, 2023

Another caveat: Intel MPI does not provide mpifort, but mpifc.

@dalcinl dalcinl marked this pull request as draft October 4, 2023 11:52
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge conda-forge deleted a comment from conda-forge-webservices bot Oct 4, 2023
@dalcinl dalcinl marked this pull request as ready for review October 17, 2023 06:52
@dalcinl
Copy link
Contributor

dalcinl commented Oct 17, 2023

@conda-forge-admin, please rerender

@dalcinl
Copy link
Contributor

dalcinl commented Oct 17, 2023

I'm merging this as it is now. I'm a bit worried the new Intel MPI builds may somehow mess the conda solver.

@jan-janssen If you see any regression in production, let me know ASAP.

@dalcinl dalcinl merged commit 4737bfe into conda-forge:main Oct 17, 2023
77 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 3.1.5_h6ccb07 branch October 17, 2023 07:53
@jan-janssen
Copy link
Member

jan-janssen commented Oct 17, 2023

@dalcinl So far everything works fine for mpich but my openmpi tests fail. I am going to look into this in more detail pyiron/executorlib#181 . To be more precise the issue appears for Python 3.9 and 3.10 but it does not appear for 3.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants