Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.09.20 #63

Merged
merged 2 commits into from
Sep 22, 2018

Conversation

dopplershift
Copy link
Member

Alternative to #62 in order to keep Python 3.7 support.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ngoldbaum ngoldbaum mentioned this pull request Sep 22, 2018
5 tasks
@ngoldbaum
Copy link

I guess we should be downloading the tarball from pypi instead of github to avoid SHA hash changes.

@dopplershift
Copy link
Member Author

Changed to point source to PyPI.

@dopplershift
Copy link
Member Author

@conda-forge-admin, please update circle

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I updated the circle-ci deploy key and followed the project.

@dopplershift
Copy link
Member Author

Let's try again.

@conda-forge-admin, please update circle

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I updated the circle-ci deploy key and followed the project.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dopplershift
Copy link
Member Author

Weird...for some reason was picking up this repo on Circle on my account. Removed repo from my account and power cycled to try to get it to work. So far seems good.

@dopplershift dopplershift merged commit 4946a0f into conda-forge:master Sep 22, 2018
@dopplershift dopplershift deleted the rerender branch September 23, 2018 04:44
@@ -5,8 +5,8 @@ package:
version: {{ version }}

source:
url: https://github.com/Unidata/netcdf4-python/archive/v{{ version }}rel.tar.gz
sha256: f6f2fc2dd80f72b5750290e8c09789bfa598cc4d1eed24c43009950624ead0b2
url: https://pypi.io/packages/source/n/netCDF4/netCDF4-{{version}}.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason for using github instead of PyPI is b/c now upstream is waiting for the wheels to build before publish the source dist on PyPI, that delays the conda-forge package quite a bit sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants