Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stub package python-ninja #32

Closed
wants to merge 1 commit into from
Closed

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Feb 21, 2023

  • forward dependency on ninja via python-ninja output
  • add metadata for pip check
  • provide possibility to use python -m ninja

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #26
Closes conda-forge/staged-recipes#19098

- forward dependency on ninja via python-ninja output
- add metadata for pip check
- provide possibility to use python -m ninja
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@henryiii
Copy link
Contributor

I still believe this is not the correct fix. This won't fix other non-conda packaging ecosystems. It should be fixed upstream in the (two known) packages that misuse it, then patched there until a new version is out. If there is a python-ninja, it should be a repacking of the actual python ninja package. If someone actually does need the Python package with jobserver support, they should be able to require it. These packages do not, but just have a faulty discovery / usage of ninja only from the package.

Trying to hack around the problem is just going to cause problems later. You can't delete the fake package once it's released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ninja package does not include python package
2 participants