-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually upgrade 0.1.3 -> to 0.1.4 #14
Conversation
…nda-forge-pinning 2024.02.23.09.37.40
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@sahiljhawar So after you merge this, then you will revert the yaml to the syntax they had before for future pypi uploads? |
Yes, I think so. By the next release if our PyPi size limit is not increased we can still use the same config. Only caveat is, we have to do it manually. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I am not sure what is going wrong. But here are my assumptions/observations:
I will do: |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.02.23.20.04.21
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/nmma-feedstock/actions/runs/8026264990. |
@conda-forge/core Hi again, I have tried multiple times (on local as well) but the pipeline never passes. I am assuming the root cause is |
I think you should have a section in your pyproject.toml called tool.setuptools see maybe |
Try;
it seems like it isn't searching through subdirectories. I haven't been too fond of the pyproject.toml transition and avoided it in my projects, but the |
But we already had 3-4 conda releases with pyproject.toml and went fine |
@sahiljhawar Is this a case where a 0.1.5 release would alleviate these issues? |
If you have a linux machine, try to do:
then activate the environment, and edit things until you see that the whole subdirectories are installed correctly. That is what I did and found that the proposed changes to the pyproject.toml worked. As I said, I had a really rough time with the pyproject.toml transition and this is par for the course. |
@mcoughlin Can't say for sure. I can try implementing Mark's suggestion and if it works maybe a 0.1.5 or uploading that local build on anaconda (if it's possible). |
@hmaarrfk I am using Github codespaces to test this out as it allows for a clean base environment (0 chances of any conflicts). |
For your reference build locally uses docker to also create the same build environment. Good luck |
Thanks @hmaarrfk. Your code snippet worked. Looks like since we changed some configuration in the |
temporary url for 0.1.4
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.03.02.16.55.54
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)