Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #87 and #82 #88

Merged
merged 2 commits into from
Jul 3, 2022
Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jul 2, 2022

I also added a pip check to prevent us from merging a bad bot PR again in the future.
Note that the tests are not passing b/c of entrypoints, maybe we are missing something in the tarball?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@joshmoore
Copy link
Member

Note that the tests are not passing b/c of entrypoints, maybe we are missing something in the tarball?

@ocefpaf, a dependency on entrypoints was added in zarr-developers/numcodecs#300

@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 2, 2022

@ocefpaf, a dependency on entrypoints was added in zarr-developers/numcodecs#300

Yep. That is why I'm adding it here :-)
Just puzzled why the tests are failing.

@xylar
Copy link

xylar commented Jul 3, 2022

Could we break this into 2 PRs, one to fix #87 (which should be trivial) and another to fix #82 (which seems to require some debugging)?

@ocefpaf ocefpaf added the automerge Merge the PR when CI passes label Jul 3, 2022
@github-actions github-actions bot merged commit e13dd05 into conda-forge:main Jul 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2022

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@ocefpaf ocefpaf deleted the fix_dependencies branch July 3, 2022 17:04
@xylar xylar mentioned this pull request Jul 26, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants