Java 9

[hadim]

Build Java 9.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[hadim]

@jakirkham Would you be ok to review this? Or ping someone who could?

[sodre]

@hadim, I don't object to bringing openjdk up-to-date. Thank you for taking the time to do that.
Ping me back once the PR is passing.

[hadim]

HOURRAA !!!

Everything looks good. CircleCi takes forever but the build works locally on my machine. Same for #35 and #36.

It will take a few hours for CircleCi to start the build. After that, it will be ready for a review.

[hadim]

All green!

[sodre]

@hadim great work! There were a few questions on my side some suggested minor changes.

It is ready to merge after that.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

• When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
• When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
• When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

• Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [45]

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[hadim]

@ctrueden I tested the Linux build locally (conda build recipe/ after cloning this recipe) and I got the following error:

$ python -c "import jnius;System = jnius.autoclass('java.lang.System');print(System.getProperty('java.version'))"

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/hadim/local/conda/envs/java/lib/python3.6/site-packages/jnius/__init__.py", line 13, in <module>
    from .reflect import *  # noqa
  File "/home/hadim/local/conda/envs/java/lib/python3.6/site-packages/jnius/reflect.py", line 15, in <module>
    class Class(with_metaclass(MetaJavaClass, JavaClass)):
  File "/home/hadim/local/conda/envs/java/lib/python3.6/site-packages/six.py", line 827, in __new__
    return meta(name, bases, d)
  File "jnius/jnius_export_class.pxi", line 111, in jnius.MetaJavaClass.__new__
  File "jnius/jnius_export_class.pxi", line 161, in jnius.MetaJavaClass.resolve_class
  File "jnius/jnius_env.pxi", line 11, in jnius.get_jnienv
  File "jnius/jnius_jvm_dlopen.pxi", line 90, in jnius.get_platform_jnienv
  File "jnius/jnius_jvm_dlopen.pxi", line 59, in jnius.create_jnienv
SystemError: Error calling dlopen(b'/home/hadim/local/conda/envs/java/jre/lib/amd64/server/libjvm.so': b'/home/hadim/local/conda/envs/java/jre/lib/amd64/server/libjvm.so: cannot open shared object file: No such file or directory'

The true location of libjvm.so is /home/hadim/local/conda/envs/java/lib/server/libjvm.so.

JAVA_HOME is supposed to be CONDA_PREFIX: /home/hadim/local/conda/envs/java

I feel like pyjnius is confused by the absence of the jre folder in Java >= 9.

Any idea?

[hadim]

Might be relevant: https://github.com/kivy/pyjnius/blob/5e19dbe425a6336e94b2f97c4b66c32ed1cd8652/jnius/jnius_jvm_dlopen.pxi#L50

Ping @hanslovsky as well.

[hadim]

Ok it's a bug in pyjnius: kivy/pyjnius#304

In consequence, we won't be able to use those builds with the scyjava ecosystem before it has been resolved.

That being said those builds are fine in my opinion and can be merged after the (hopefully!) last review by @sodre.

[ctrueden]

@hadim Why is Java 9 in the mix? Why wasn't your test using OpenJDK 8?

[hadim]

Sorry, it wasn't clear. My test with all-already-released Conda packages including OpenJDK 8 is working fine. Here I was testing this OpenJDK 9 PR by building it locally with conda build.

[hadim]

So to summarize those OpenJDK 9, 10 and 11 PRs are working fine but we won't be able to use those with pyjnius and packages that depend on it before kivy/pyjnius#304 is fixed.

Is that clear?

[hadim]

@sodre I think #34, #35 and #36 are ready to be reviewed.

[jakirkham]

We probably should add a compiler requirement in test and update this to $CC.

[jakirkham]

Broke out in issue ( #41 ).

[jakirkham]

Is this still being used? Looks like it might not be.

[jakirkham]

Broke out as issue ( #40 ).

[jakirkham]

Thanks again for working on this, @hadim. Definitely a much needed improvement for the recipe.

Made some small notes above about a few things we could cleanup. Though have broken these out as issues after the fact for easier tracking. Admittedly these may be carried over from my own PR. So sorry about that. They shouldn't be difficult to address.