Skip to content

Commit

Permalink
Fixes for 2023.0.1 release (#24)
Browse files Browse the repository at this point in the history
  • Loading branch information
ilya-lavrenov authored Jul 20, 2023
1 parent b98fdb0 commit 5696ddb
Show file tree
Hide file tree
Showing 6 changed files with 103 additions and 35 deletions.
14 changes: 6 additions & 8 deletions recipe/bld.bat
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,16 @@ cmake ^
-DENABLE_SAMPLES=OFF ^
-DENABLE_DATA=OFF ^
-DCPACK_GENERATOR=CONDA-FORGE ^
-G Ninja ^
-G "Visual Studio 16 2019" ^
-S "%SRC_DIR%" ^
-B "%SRC_DIR%/build"
-B "%SRC_DIR%\build"
if errorlevel 1 exit 1

cmake --build "%SRC_DIR%/build" --config Release --parallel %CPU_COUNT% --verbose
cmake --build "%SRC_DIR%\build" --config Release --parallel %CPU_COUNT% --verbose
if errorlevel 1 exit 1

cp "%SRC_DIR%/LICENSE" LICENSE
cp "%SRC_DIR%/licensing/third-party-programs.txt" third-party-programs.txt
cp "%SRC_DIR%/licensing/onednn_third-party-programs.txt" onednn_third-party-programs.txt
cp "%SRC_DIR%/licensing/runtime-third-party-programs.txt" runtime-third-party-programs.txt
cp "%SRC_DIR%/licensing/tbb_third-party-programs.txt" tbb_third-party-programs.txt
COPY "%SRC_DIR%\licensing\third-party-programs.txt" third-party-programs.txt
COPY "%SRC_DIR%\licensing\onednn_third-party-programs.txt" onednn_third-party-programs.txt
COPY "%SRC_DIR%\licensing\runtime-third-party-programs.txt" runtime-third-party-programs.txt

exit 0
2 changes: 0 additions & 2 deletions recipe/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ cmake ${CMAKE_ARGS} \

cmake --build "$SRC_DIR/build" --config Release --parallel $CPU_COUNT --verbose

cp "$SRC_DIR/LICENSE" LICENSE
cp "$SRC_DIR/licensing/third-party-programs.txt" third-party-programs.txt
cp "$SRC_DIR/licensing/onednn_third-party-programs.txt" onednn_third-party-programs.txt
cp "$SRC_DIR/licensing/runtime-third-party-programs.txt" runtime-third-party-programs.txt
cp "$SRC_DIR/licensing/tbb_third-party-programs.txt" tbb_third-party-programs.txt
21 changes: 5 additions & 16 deletions recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ source:
- patches/001-win64-find-ocl.patch # [win64]
- patches/003-lin-arm64-compute-lib.patch # [aarch64]
- patches/004-mha-build-fix.patch # [arm64]
- patches/005-cross-compilation-macos.patch
- patches/006-remove-mp.patch # [win64]
- url: https://github.com/ARM-software/ComputeLibrary/archive/refs/tags/v23.02.1.tar.gz # [aarch64 or arm64]
sha256: c3a443e26539f866969242e690cf0651ef629149741ee18732f954c734da6763 # [aarch64 or arm64]
folder: src/plugins/intel_cpu/thirdparty/ComputeLibrary # [aarch64 or arm64]
Expand All @@ -32,7 +34,7 @@ source:
folder: thirdparty/onnx/onnx

build:
number: 1
number: 2
run_exports:
- {{ pin_subpackage('libopenvino', max_pin='x.x.x') }}
- {{ pin_subpackage('libopenvino-intel-cpu-plugin', max_pin='x.x.x') }} # [x86_64]
Expand Down Expand Up @@ -73,7 +75,8 @@ requirements:
- khronos-opencl-icd-loader # [win64]
- pugixml >=1.12.1 # starting from this version shared libraries are provided
- xbyak >=6.69.1 # [x86_64]
- libprotobuf-static =3.20.3
- libprotobuf-static =3.20.3 # [not win64]
- libprotobuf-static # [win64]
run:
- {{ pin_subpackage('libopenvino', max_pin='x.x.x') }}
- {{ pin_subpackage('libopenvino-intel-cpu-plugin', max_pin='x.x.x') }} # [x86_64]
Expand Down Expand Up @@ -170,7 +173,6 @@ outputs:
- third-party-programs.txt
- onednn_third-party-programs.txt
- runtime-third-party-programs.txt
- tbb_third-party-programs.txt
build:
run_exports:
- {{ pin_subpackage('libopenvino', max_pin='x.x.x') }}
Expand Down Expand Up @@ -203,7 +205,6 @@ outputs:
- third-party-programs.txt
- onednn_third-party-programs.txt
- runtime-third-party-programs.txt
- tbb_third-party-programs.txt
build:
run_exports:
- {{ pin_subpackage('libopenvino', max_pin='x.x.x') }}
Expand Down Expand Up @@ -233,7 +234,6 @@ outputs:
- third-party-programs.txt
- onednn_third-party-programs.txt
- runtime-third-party-programs.txt
- tbb_third-party-programs.txt
build:
run_exports:
- {{ pin_subpackage('libopenvino', max_pin='x.x.x') }}
Expand Down Expand Up @@ -262,7 +262,6 @@ outputs:
- third-party-programs.txt
- onednn_third-party-programs.txt
- runtime-third-party-programs.txt
- tbb_third-party-programs.txt
build:
run_exports:
- {{ pin_subpackage('libopenvino', max_pin='x.x.x') }}
Expand Down Expand Up @@ -291,7 +290,6 @@ outputs:
- third-party-programs.txt
- onednn_third-party-programs.txt
- runtime-third-party-programs.txt
- tbb_third-party-programs.txt
build:
run_exports:
- {{ pin_subpackage('libopenvino', max_pin='x.x.x') }}
Expand Down Expand Up @@ -320,7 +318,6 @@ outputs:
- third-party-programs.txt
- onednn_third-party-programs.txt
- runtime-third-party-programs.txt
- tbb_third-party-programs.txt
build:
run_exports:
- {{ pin_subpackage('libopenvino', max_pin='x.x.x') }}
Expand Down Expand Up @@ -350,7 +347,6 @@ outputs:
- third-party-programs.txt
- onednn_third-party-programs.txt
- runtime-third-party-programs.txt
- tbb_third-party-programs.txt
build:
run_exports:
- {{ pin_subpackage('libopenvino', max_pin='x.x.x') }}
Expand Down Expand Up @@ -379,7 +375,6 @@ outputs:
- third-party-programs.txt
- onednn_third-party-programs.txt
- runtime-third-party-programs.txt
- tbb_third-party-programs.txt
build:
skip: True # [not x86_64]
run_exports:
Expand Down Expand Up @@ -410,7 +405,6 @@ outputs:
- third-party-programs.txt
- onednn_third-party-programs.txt
- runtime-third-party-programs.txt
- tbb_third-party-programs.txt
build:
skip: True # [not aarch64 and not arm64]
run_exports:
Expand Down Expand Up @@ -440,7 +434,6 @@ outputs:
- third-party-programs.txt
- onednn_third-party-programs.txt
- runtime-third-party-programs.txt
- tbb_third-party-programs.txt
build:
skip: True # [not linux64 and not win64]
run_exports:
Expand Down Expand Up @@ -475,7 +468,6 @@ outputs:
- third-party-programs.txt
- onednn_third-party-programs.txt
- runtime-third-party-programs.txt
- tbb_third-party-programs.txt
build:
run_exports:
- {{ pin_subpackage('libopenvino-auto-plugin', max_pin='x.x.x') }}
Expand Down Expand Up @@ -504,7 +496,6 @@ outputs:
- third-party-programs.txt
- onednn_third-party-programs.txt
- runtime-third-party-programs.txt
- tbb_third-party-programs.txt
build:
run_exports:
- {{ pin_subpackage('libopenvino-auto-batch-plugin', max_pin='x.x.x') }}
Expand Down Expand Up @@ -532,7 +523,6 @@ outputs:
- third-party-programs.txt
- onednn_third-party-programs.txt
- runtime-third-party-programs.txt
- tbb_third-party-programs.txt
build:
run_exports:
- {{ pin_subpackage('libopenvino-hetero-plugin', max_pin='x.x.x') }}
Expand Down Expand Up @@ -576,7 +566,6 @@ about:
- third-party-programs.txt
- onednn_third-party-programs.txt
- runtime-third-party-programs.txt
- tbb_third-party-programs.txt
doc_url: https://docs.openvino.ai/latest/index.html
dev_url: https://github.com/openvinotoolkit/openvino

Expand Down
75 changes: 66 additions & 9 deletions recipe/patches/001-win64-find-ocl.patch
Original file line number Diff line number Diff line change
@@ -1,12 +1,69 @@
diff --git a/thirdparty/CMakeLists.txt b/thirdparty/CMakeLists.txt
index edbcb824f4..b21569956d 100644
index 95d80a6fbd..5c827d7da2 100644
--- a/thirdparty/CMakeLists.txt
+++ b/thirdparty/CMakeLists.txt
@@ -44,6 +44,7 @@ if(ENABLE_INTEL_GPU)
find_package(OpenCLHeaders QUIET)
if(NOT OpenCLHeaders_FOUND)
message(WARNING "OpenCLHeaders not found, but OpenCLICDLoader is installed. Please, install OpenCL headers")
+ find_package(OpenCL QUIET)
else()
set_target_properties(OpenCL::Headers PROPERTIES IMPORTED_GLOBAL ON)
endif()
@@ -58,44 +58,7 @@ endif()

if(ENABLE_INTEL_GPU)
if(ENABLE_SYSTEM_OPENCL)
- # try to find system OpenCL:
- # - 'brew install opencl-icd-loader'
- # - 'conan install opencl-icd-loader'
- find_package(OpenCLICDLoader QUIET)
-
- if(OpenCLICDLoader_FOUND)
- # examples:
- # - 'brew install opencl-headers'
- # - 'conan install opencl-headers'
- find_package(OpenCLHeaders QUIET)
- if(NOT OpenCLHeaders_FOUND)
- message(WARNING "OpenCLHeaders not found, but OpenCLICDLoader is installed. Please, install OpenCL headers")
- else()
- set_target_properties(OpenCL::Headers PROPERTIES IMPORTED_GLOBAL ON)
- set_property(TARGET OpenCL::OpenCL APPEND PROPERTY INTERFACE_LINK_LIBRARIES OpenCL::Headers)
- endif()
-
- # examples:
- # - 'brew install opencl-clhpp-headers'
- # - 'conan install opencl-clhpp-headers'
- find_package(OpenCLHeadersCpp QUIET)
- if(NOT OpenCLHeadersCpp_FOUND)
- message(WARNING "OpenCLHeadersCpp not found, but OpenCLICDLoader is installed. Please, install OpenCL C++ headers")
- else()
- set_target_properties(OpenCL::HeadersCpp PROPERTIES IMPORTED_GLOBAL ON)
- get_target_property(opencl_cpp_include_dirs OpenCL::HeadersCpp INTERFACE_INCLUDE_DIRECTORIES)
- set_property(TARGET OpenCL::OpenCL APPEND PROPERTY INTERFACE_LINK_LIBRARIES OpenCL::HeadersCpp)
- endif()
-
- # set OpenCLICDLoader_FOUND to parent scope to generate proper OpenVINOConfig.cmake for static libraries case
- set(OpenCLICDLoader_FOUND ON PARENT_SCOPE)
- else()
- # try to find system OpenCL:
- # - 'apt-get install opencl-headers ocl-icd-opencl-dev'
- # - 'yum install ocl-icd-devel opencl-headers'
- # - 'conda install khronos-opencl-icd-loader -c conda-forge'
- find_package(OpenCL QUIET)
- endif()
+ find_package(OpenCL QUIET)
endif()

if(TARGET OpenCL::OpenCL)
@@ -120,18 +83,6 @@ if(ENABLE_INTEL_GPU)
set_target_properties(OpenCL::OpenCL PROPERTIES
INTERFACE_COMPILE_DEFINITIONS "${opencl_interface_definitions}")
endif()
-
- # set variables for onednn_gpu
- if(OpenCLHeaders_FOUND)
- set(OpenCL_INCLUDE_DIR "$<TARGET_PROPERTY:OpenCL::Headers,INTERFACE_INCLUDE_DIRECTORIES>" PARENT_SCOPE)
- set(OpenCL_LIBRARY "$<TARGET_PROPERTY:OpenCL::OpenCL,IMPORTED_LOCATION_RELEASE>" PARENT_SCOPE)
- elseif(OpenCL_FOUND)
- # find_package(OpenCL) already defines OpenCL_INCLUDE_DIR and OpenCL_LIBRARY
- # see https://cmake.org/cmake/help/latest/module/FindOpenCL.html
- message(STATUS "Found OpenCL (ver. ${OpenCL_VERSION_STRING}, include dirs ${OpenCL_INCLUDE_DIRS})")
- else()
- message(FATAL_ERROR "Internal error: cannot find OpenCL headers")
- endif()
else()
add_subdirectory(ocl)

13 changes: 13 additions & 0 deletions recipe/patches/005-cross-compilation-macos.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/cmake/templates/OpenVINOConfig.cmake.in b/cmake/templates/OpenVINOConfig.cmake.in
index 986232d414..e6786f5a9d 100644
--- a/cmake/templates/OpenVINOConfig.cmake.in
+++ b/cmake/templates/OpenVINOConfig.cmake.in
@@ -409,7 +409,7 @@ function(_ov_target_no_deprecation_error)
else()
set(flags "-Wno-error=deprecated-declarations")
endif()
- if(CMAKE_CROSSCOMPILING)
+ if(CMAKE_CROSSCOMPILING AND NOT APPLE)
set_target_properties(${ARGV} PROPERTIES
INTERFACE_LINK_OPTIONS "-Wl,--allow-shlib-undefined")
endif()
13 changes: 13 additions & 0 deletions recipe/patches/006-remove-mp.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/cmake/developer_package/compile_flags/os_flags.cmake b/cmake/developer_package/compile_flags/os_flags.cmake
index 7d34c308f3..5119da0717 100644
--- a/cmake/developer_package/compile_flags/os_flags.cmake
+++ b/cmake/developer_package/compile_flags/os_flags.cmake
@@ -346,7 +346,7 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
# Increase Number of Sections in .Obj file
ie_add_compiler_flags(/bigobj)
# Build with multiple processes
- ie_add_compiler_flags(/MP)
+ # ie_add_compiler_flags(/MP)

if(AARCH64 AND NOT MSVC_VERSION LESS 1930)
# otherwise, _ARM64_EXTENDED_INTRINSICS is defined, which defines 'mvn' macro

1 comment on commit 5696ddb

@conda-forge-webservices
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

You should get push access to this feedstock and CI services.

Your package won't be available for installation locally until it is built
and synced to the anaconda.org CDN (takes 1-2 hours after the build finishes).

Feel free to join the community Element channel.

NOTE: Please make sure to not push to the repository directly.
Use branches in your fork for any changes and send a PR.
More details on this are here.

Please sign in to comment.