Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for pypy #78

Merged
merged 7 commits into from
Apr 16, 2020
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update pypy.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:
adaptive-scheduler
airflow
allensdk
alpenglow
bcolz
And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://circleci.com/gh/regro/circle_worker/15048, please use this URL for debugging

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

@conda-forge-admin, please restart ci

@h-vetinari
Copy link
Member

@conda-forge-admin, please rerender

@h-vetinari
Copy link
Member

Seems the problem was that the pypy build was looking for a numpy version that hadn't been built for pypy, but the rerender solved that problem. :)

@h-vetinari
Copy link
Member

All the travis builds on Aarch stalled hard. Maybe someone should manually kick them to restart (I don't have the rights).

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Apr 16, 2020 via email

@h-vetinari
Copy link
Member

@TomAugspurger: I'm not sure if the Aarch builds have ever completed.

Interestingly, while the last run (for 1.0.3) errored, the builds nevertheless succeeded somehow and are seeing downloads.

@h-vetinari
Copy link
Member

@h-vetinari: Interestingly, while the last run (for 1.0.3) errored, the builds nevertheless succeeded somehow and are seeing downloads.

Actually, that's possibly a pretty serious issue (CI seemingly stalled, yet packages getting uploaded) that's happened at least for the last two pandas (patch) releases. CC @conda-forge/core

@xhochy
Copy link
Member

xhochy commented Apr 16, 2020

ppc64le is still at v0.25.3, so there were no spurious uploads happening. Note that aarch64 builds run on drone.io, travis only builds ppc64le.

@xhochy
Copy link
Member

xhochy commented Apr 16, 2020

@conda-forge-admin please rerender

@h-vetinari
Copy link
Member

@xhochy: ppc64le is still at v0.25.3, so there were no spurious uploads happening. Note that aarch64 builds run on drone.io, travis only builds ppc64le.

Right, sorry for getting my wires crossed on that 😅

@h-vetinari
Copy link
Member

Right, so it seems the ppc64le builds are extremely slow (~2h for cpython, 2:50h for pypy), but they succeed on azure!

Maybe they wouldn't even be timing out on travis if they were left to run, rather than killed after 10 min with no output (but even then, travis wouldn't be an alternative because the build times are much longer than their default timeout of 50/60 min).

@xhochy
Copy link
Member

xhochy commented Apr 16, 2020

Travis should be able to build them faster as Azure is virtualized and Travis would run natively on ppc64le.

@isuruf
Copy link
Member

isuruf commented Apr 16, 2020

azure is running under qemu which was like 6x slower for the numpy build.

@xhochy
Copy link
Member

xhochy commented Apr 16, 2020

@conda-forge/pandas This is ready for review. I moved the ppc64le build to Azure to get it passing bu t it now takes very long. Moving it back to Travis would improve the times again but sadly the build stalls after 10min.

@TomAugspurger
Copy link
Contributor

I suspect none of the pandas maintainers have experience with pypy or power. I'm happy to defer to the CF experts here.

@isuruf isuruf merged commit 0d47b1a into conda-forge:master Apr 16, 2020
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-pypy-0-1 branch April 16, 2020 21:16
@h-vetinari h-vetinari mentioned this pull request Apr 16, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants