Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peft v0.7.1 #11

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Dec 12, 2023

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by grayskull shows no discrepancy with the stated requirements in the meta.yaml.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7188052607, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@weiji14
Copy link
Member

weiji14 commented Dec 13, 2023

Getting this error at https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=842710&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=986b1512-c876-5f92-0d81-ba851554a0a3&l=521:

import: 'peft'
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/peft_1702421290489/test_tmp/run_test.py", line 2, in <module>
    import peft
  File "/home/conda/feedstock_root/build_artifacts/peft_1702421290489/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.12/site-packages/peft/__init__.py", line 22, in <module>
    from .auto import (
  File "/home/conda/feedstock_root/build_artifacts/peft_1702421290489/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.12/site-packages/peft/auto.py", line 30, in <module>
    from .config import PeftConfig
  File "/home/conda/feedstock_root/build_artifacts/peft_1702421290489/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.12/site-packages/peft/config.py", line 22, in <module>
    from transformers.utils import PushToHubMixin
ImportError: cannot import name 'PushToHubMixin' from 'transformers.utils' (/home/conda/feedstock_root/build_artifacts/peft_1702421290489/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.12/site-packages/transformers/utils/__init__.py)
WARNING: Tests failed for peft-0.7.1-pyhd8ed1ab_0.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
TESTS FAILED: peft-0.7.1-pyhd8ed1ab_0.conda

Seems like the installed version of transformers=4.17.0 isn't compatible with peft=0.7.1. From what I can tell, that PushToHubMixin class was added in huggingface/transformers#11328 (v4.6.0), but then moved to another place in huggingface/transformers#16264, so would require transformers>=4.18.0 at least? Gonna set a minimum pin to see.

To fix error like `ImportError: cannot import name 'PushToHubMixin' from 'transformers.utils'` when importing peft in Python.
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, pinning to transformes>=4.18.0 worked!

@weiji14 weiji14 merged commit 72a0fdd into conda-forge:main Dec 13, 2023
3 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.7.1_ha2f21d branch December 13, 2023 00:37
@weiji14 weiji14 mentioned this pull request Jan 30, 2024
3 tasks
weiji14 added a commit to regro-cf-autotick-bot/peft-feedstock that referenced this pull request Jan 30, 2024
weiji14 added a commit that referenced this pull request Jan 30, 2024
* updated v0.8.0

* MNT: Re-rendered with conda-build 3.28.4, conda-smithy 3.30.4, and conda-forge-pinning 2024.01.30.06.52.51

* Pin minimum version of transformers to 4.18.0

Xref 63e75c7 in #11.

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14 added a commit to regro-cf-autotick-bot/peft-feedstock that referenced this pull request Jan 30, 2024
weiji14 added a commit that referenced this pull request Jan 30, 2024
* updated v0.8.1

* Remove hadim

* Pin minimum version of transformers to 4.18.0

Xref 63e75c7 in #11.

* MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.30.4, and conda-forge-pinning 2024.01.22.14.29.27

---------

Co-authored-by: Hadrien Mary <hadim@users.noreply.github.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14 added a commit to regro-cf-autotick-bot/peft-feedstock that referenced this pull request Feb 1, 2024
weiji14 added a commit that referenced this pull request Feb 1, 2024
* updated v0.8.2

* Pin minimum version of transformers to 4.18.0

Xref 63e75c7 in #11.

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14 added a commit to regro-cf-autotick-bot/peft-feedstock that referenced this pull request Mar 4, 2024
weiji14 added a commit that referenced this pull request Mar 4, 2024
* updated v0.9.0

* MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.31.1, and conda-forge-pinning 2024.02.27.06.32.03

* Pin minimum version of transformers to 4.18.0

Xref 63e75c7 in #11.

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14 added a commit to regro-cf-autotick-bot/peft-feedstock that referenced this pull request Mar 22, 2024
weiji14 added a commit that referenced this pull request Mar 22, 2024
* updated v0.10.0

* MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.32.0, and conda-forge-pinning 2024.03.21.10.02.09

* Pin minimum version of transformers to 4.18.0

Xref 63e75c7 in #11.

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14 added a commit to regro-cf-autotick-bot/peft-feedstock that referenced this pull request May 16, 2024
weiji14 added a commit that referenced this pull request May 16, 2024
* updated v0.11.0

* Pin minimum version of transformers to 4.18.0

Xref 63e75c7 in #11.

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14 added a commit to regro-cf-autotick-bot/peft-feedstock that referenced this pull request May 18, 2024
weiji14 added a commit that referenced this pull request May 18, 2024
* updated v0.11.1

* Pin minimum version of transformers to 4.18.0

Xref 63e75c7 in #11.

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14 added a commit to regro-cf-autotick-bot/peft-feedstock that referenced this pull request Jul 24, 2024
weiji14 added a commit that referenced this pull request Jul 24, 2024
* updated v0.12.0

* MNT: Re-rendered with conda-build 24.5.1, conda-smithy 3.37.1, and conda-forge-pinning 2024.07.24.15.58.55

* Pin minimum version of transformers to 4.18.0

Xref 63e75c7 in #11.

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14 added a commit to regro-cf-autotick-bot/peft-feedstock that referenced this pull request Sep 25, 2024
weiji14 added a commit that referenced this pull request Sep 25, 2024
* updated v0.13.0

* MNT: Re-rendered with conda-build 24.9.0, conda-smithy 3.40.1, and conda-forge-pinning 2024.09.25.17.37.07

* Pin minimum version of transformers to 4.18.0

Xref 63e75c7 in #11.

* Add setuptools as host dependency

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14 added a commit to regro-cf-autotick-bot/peft-feedstock that referenced this pull request Oct 8, 2024
weiji14 added a commit that referenced this pull request Oct 8, 2024
* updated v0.13.1

* Pin minimum version of transformers to 4.18.0

Xref 63e75c7 in #11.

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14 added a commit to regro-cf-autotick-bot/peft-feedstock that referenced this pull request Oct 13, 2024
weiji14 added a commit that referenced this pull request Oct 13, 2024
* updated v0.13.2

* MNT: Re-rendered with conda-build 24.9.0, conda-smithy 3.42.1, and conda-forge-pinning 2024.10.11.13.54.02

* Pin minimum version of transformers to 4.18.0

Xref 63e75c7 in #11.

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14 added a commit to regro-cf-autotick-bot/peft-feedstock that referenced this pull request Dec 8, 2024
weiji14 added a commit that referenced this pull request Dec 8, 2024
* updated v0.14.0

* MNT: Re-rendered with conda-build 24.11.2, conda-smithy 3.44.9, and conda-forge-pinning 2024.12.06.19.20.35

* Pin minimum version of transformers to 4.18.0

Xref 63e75c7 in #11.

* Bump minimum Python from 3.8 to 3.9, and use CFEP-25 syntax

Xref huggingface/peft#2135 and https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants