-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poetry v1.8.3 #99
poetry v1.8.3 #99
Conversation
…nda-forge-pinning 2024.05.08.19.32.07
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I think the linter was complaining when it shouldn't but it's easy to hide by switching to |
@conda-forge-admin, please rerender |
Just making sure conda-smithy won't get confused by the change I made. |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/poetry-feedstock/actions/runs/9010769264. |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
@xylar, something's off with my understanding of this trick of requiring the virtual packages. My evidently-incorrect understanding is that the Do you understand what is going on? How can the selectors distinguish between osx and linux when we require only |
@maresb, I was just following the knowledge base. But my understanding is that the |
The virtual packages are created here in conda (I think, has been a while since I checked that) and are just true for whatever platform you specify them. The reason poetry-feedstock/conda-forge.yml Lines 9 to 12 in 599a633
That means that only the OSX build will resolve to true and include A normal noarch package will build only on Linux so there it wouldn't work. (At least that's how I understood your question?) |
Taking a fresh look at this, it seems to me like I believe we're generating two interchangeable Unfortunately now I can successfully solve for an environment which should be inconsistent (via
And indeed it's picking the Linux build without xattr. To avoid problems, perhaps we should revert the |
Hmm I haven't tested it yet but that does make sense, true. I have a Mac, anything specific I should test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Bastian! 🙏
Appreciate you pointing out this issue to us in comment: conda-forge/conda-forge.github.io#2102 (comment)
Would suggest ignoring the linter in this case. We probably need to fix the linter somehow. If you have time to file a conda-smithy bug referencing this issue, that would be very helpful 🙂
@@ -59,9 +59,8 @@ requirements: | |||
- xattr >=1.0.0,<2.0.0 # [osx] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think the challenge with using __unix
here is this dependency will either install on macOS and Linux or it will be ignored altogether
Instead would suggest ignoring the linter and sticking with what you had before
- __unix # [unix] | ||
- __win # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IOW keeping the Linux and macOS distinction here
- __unix # [unix] | |
- __win # [win] | |
- __linux # [linux] | |
- __osx # [osx] | |
- __win # [win] |
@BastianZim you could try |
Yes, it installs |
Thanks John! Will roll that back then and mark that version as broken. |
New PR is in #100 |
Package is marked as broken in conda-forge/admin-requests#991 |
Sorry about all this! I appreciate all of you help! |
No worries @xylar, given all the amazing wide-reaching stuff you're constantly doing, it's quite remarkable how infrequently anything goes wrong! |
Yeah, sorry also from my side for the misleading linter warning, and thanks everyone for fixing it! |
Thanks everyone for the quick help and feedback! I can only agree with Ben, at this scale, it's incredibly impressive how well everything is working. And all on volunteer time! ❤️ |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: disabled
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by grayskull shows a discrepancy between it and the the package's stated requirements in the meta.yaml.
Packages found by grayskull but not in the meta.yaml:
Packages found in the meta.yaml but not found by grayskull:
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/9009011030 - please use this URL for debugging.