Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefect v0.5.3 #6

Merged
merged 2 commits into from
May 7, 2019
Merged

prefect v0.5.3 #6

merged 2 commits into from
May 7, 2019

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.
Notes and instructions for merging this PR:

  1. Please check that the dependencies have not changed.
  2. Please merge the PR only after the tests have passed.
  3. Feel free to push to the bot's branch to update this PR if needed.
  4. The bot will almost always only open one PR per version.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@cicdw
Copy link
Contributor

cicdw commented May 7, 2019

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@cicdw cicdw merged commit 6a2eb73 into conda-forge:master May 7, 2019
@cicdw cicdw mentioned this pull request May 8, 2019
5 tasks
@dhirschfeld
Copy link
Member

It looks like the CI didn't like the merge:

image

Clicking on the red cross takes you to the details page:

image

...where you can choose to re-run the CI.

I'll go ahead and do that in the hope that it was just an intermittent issue.

@dhirschfeld
Copy link
Member

It's now in progress again...
image

🤞

@dhirschfeld
Copy link
Member

dhirschfeld commented May 8, 2019

Downloading https://github.com/PrefectHQ/prefect/archive/0.5.3.tar.gz
Success
INFO:conda_build.source:Success
SHA256 mismatch: '5bce142269a90a76a8a96ade6346cc4377e6b73a3db99bc9c048ebc4718c4c10' != '56bd7d045b049435feadf88fb9d8018690701d1ccacec5c399d125a5436bc2ea'

image

@dhirschfeld
Copy link
Member

Looks like the bot got the hash wrong??

(base) ~\code> Get-FileHash -Path $pth | fl

Algorithm : SHA256
Hash      : 5BCE142269A90A76A8A96ADE6346CC4377E6B73A3DB99BC9C048EBC4718C4C10
Path      : ~\Downloads\prefect-0.5.3.tar.gz

@dhirschfeld
Copy link
Member

@cicdw - is there any way the hash of the github tarball could have changed??

@dhirschfeld
Copy link
Member

Did the tag change? Was master force-pushed? I wouldn't imagine so but then it seems impossible that that hash should have changed.

@dhirschfeld dhirschfeld mentioned this pull request May 8, 2019
@cicdw
Copy link
Contributor

cicdw commented May 8, 2019

Oh weird - good detective work! There have been normal merges to master since the release was cut, but not to the tagged commit. Also 56bd7d045b049435feadf88fb9d8018690701d1ccacec5c399d125a5436bc2ea is what I computed for the hash, which agrees with the bot.

@dhirschfeld
Copy link
Member

If you re-download and re-compute the hash do you still get the same result?

As shown above when I just did it then I got the same result as Azure CI which was different from the bot

@cicdw
Copy link
Contributor

cicdw commented May 8, 2019

No I don't:

openssl dgst -sha256 prefect-0.5.3.tar.gz 
SHA256(prefect-0.5.3.tar.gz)= 5bce142269a90a76a8a96ade6346cc4377e6b73a3db99bc9c048ebc4718c4c10

That is really surprising

@cicdw
Copy link
Contributor

cicdw commented May 8, 2019

@dhirschfeld
Copy link
Member

Could be #7 is the way to go

@cicdw
Copy link
Contributor

cicdw commented May 8, 2019

I'm cool with that, thanks a million for the help!

@dhirschfeld
Copy link
Member

I just tested and get different hashes if I download from github via curl or via my browser so it seems a bit flaky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants