Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to getting source from pypi #168

Closed
wants to merge 2 commits into from

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Oct 26, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xylar
Copy link
Contributor Author

xylar commented Oct 26, 2022

@conda-forge-admin, please rerender

@xylar
Copy link
Contributor Author

xylar commented Oct 26, 2022

A local CPython and PyPy test both worked so I'm hopeful that this will work here, too.

@xylar
Copy link
Contributor Author

xylar commented Oct 26, 2022

@conda-forge/protobuf, I am pretty new as a maintainer here. Do any of you know if there's a good reason we haven't been using source from PyPI?

It initially seemed that this might help us with #167. However, it sounds like that isn't the case, see protocolbuffers/protobuf#10305 (comment)

@xylar xylar marked this pull request as draft October 26, 2022 19:51
@xylar xylar closed this Oct 26, 2022
@xylar
Copy link
Contributor Author

xylar commented Oct 26, 2022

I don't think this is going to solve any problems so let's not do this.

@xylar xylar deleted the switch_to_pypi branch October 26, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants