-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependency on correct pybind11-abi package and add test to check that the correct abi version is used #105
Conversation
…that the correct abi version is used
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.09.22.11.38.10
This isn’t true anymore, the latest versions of the last three releases don’t require matching ABI versions anymore. |
Only the platform part needs to match, the internals ABI version does not matter anymore. Though both extensions need to be compiled with the last release of 2.11, 2.12, or 2.13. |
Thanks for the input! Is this related to pybind/pybind11#5296 ? |
Yes, that’s it. We probably should make branches and build 2.11.2 and 2.12.1. And I’m assuming we would like to try to get conda-forge packages to rebuild with the latest pybind11 releases. |
Probably we need anyhow to distinguish somehow packages built before and after pybind/pybind11#5296 . Perhaps we could bump pybind11-abi to some arbitrary number (like 10) to signal that |
Let's move the discussion back on the issues, for now this can be closed. |
Fix #96
Fix part P1 of #95 (see #95 (comment)).
As now the abi version is no uniquely determined by the pybind11 version, the test on
pybind11-abi
package just check if the set abi is among the one defined in the header (see AnacondaRecipes#15), while the actual tested is moved to thepybind11
package, where it is indeed checked that the value of the macroPYBIND11_INTERNALS_VERSION
actually defined matches the value used in therun_export
.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)