Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pybind11-abi to 10 to reflect the fact that PYBIND11_INTERNALS_ID is not used anymore to track compatibility #106

Closed
wants to merge 3 commits into from

Conversation

traversaro
Copy link

@traversaro traversaro commented Sep 26, 2024

See discussion in #96 (comment) .

The idea is that since pybind/pybind11#5296 PYBIND11_INTERNALS_ID is not used anymore to assess compatibility between library compiled with different pybind11 versions, it does not make sense anymore for pybind11-abi to track PYBIND11_INTERNALS_ID.

For this reason, this PR also remove the check that pybind11-abi is equal to PYBIND11_INTERNALS_ID.

Fix #96 .

Note that this will not solve or handle the fact that pybind11 bindings compiled with different gcc or clang major versions (#77) or msvc minor versions (#95) are incompatible.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro
Copy link
Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Author

fyi @conda-forge/pybind11

Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • It looks like the 'pybind11-abi' output doesn't have any tests.

Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@henryiii
Copy link
Contributor

On hold while we discuss pybind/pybind11#5296 (comment)

@traversaro
Copy link
Author

As work for solving the various issue affecting pybind11 was merged in pybind/pybind11#4953, probably it make sense to close this issue and revise the pybind11-abi functionality once a release that contains #104 . However, to ensure that a new release does not get released without appropriate changes to pybind11-abi, I think it would be helpful to merge #104 .

@traversaro traversaro closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pybind11-abi test script is silently broken for pybind11 2.12, and may be missing ABI version 5
2 participants