Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for PyPy3.7 for windows #27

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update pypy37-windows.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/982559610, please use this URL for debugging

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@pkgw
Copy link
Contributor

pkgw commented Jul 4, 2021

The Windows build script seems to have some issue with PyPy's paths — there are some uncaught errors in the batch script output.

@mattip
Copy link

mattip commented Sep 12, 2021

@conda-forge-admin please rerender

@mattip
Copy link

mattip commented Sep 12, 2021

I think this is still off. What is meant to create %PREFIX%\Library\lib\python* under CPython?

%BUILD_PREFIX%) %SRC_DIR%>cd %PREFIX%\Library\lib\python* 
The filename, directory name, or volume label syntax is incorrect.

The system cannot find the path specified.
(%BUILD_PREFIX%) %SRC_DIR%>cd site-packages 

@pkgw
Copy link
Contributor

pkgw commented Sep 13, 2021

@mattip It depends on what you're asking. You may already be aware of this, but the output from the build is postprocessed by the conda-build program to make it a bit easier to read. The conda install prefix, which is usually a very long path, is replaced by the string %PREFIX%, so the directory that was actually created was something like C:\conda\conda-build\...verylongprefixwithlotsofcharacters...\Library\lib\python*. During the build there is actually a %PREFIX% environment variable defined, but the replacement is an independent filter that's applied to the build output unconditionally.

Anyway, at the higher level, it looks like the bld.bat script has some steps that assume CPython and don't work for PyPy. If you look at the build.sh, there's similar code that detects the Python implementation and alters its behavior based on that. The bld.bat script probably needs an analogous change too.

@ryanvolz
Copy link
Contributor

Since we already have to move the Python libraries to the proper location on Windows, the fix was pretty easy to have it account for PyPy as well. This should be good to go (assuming the remaining builds as of this writing will pass successfully).

@pkgw
Copy link
Contributor

pkgw commented Sep 14, 2021

Thanks @ryanvolz!

@pkgw pkgw merged commit 5631469 into conda-forge:master Sep 14, 2021
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-pypy37-windows-0-1_hba4748 branch September 14, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants