Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows compilers #97

Closed
h-vetinari opened this issue Feb 4, 2024 · 2 comments
Closed

Update windows compilers #97

h-vetinari opened this issue Feb 4, 2024 · 2 comments

Comments

@h-vetinari
Copy link
Member

Hey all

This feedstock is directly specifying vs2017_win-64 as a dependency,

requirements:
build:
- python # [build_platform != target_platform]
- cross-python_{{ target_platform }} # [build_platform != target_platform]
- setuptools # [build_platform != target_platform]
- {{ compiler('cxx') }} # [linux or osx]
- vs2017_win-64 # [win]

but should just rely on the {{ compiler('c') }} function to provide the correct compilers on windows. In particular, conda-forge has moved on to vs2019 as the default compiler a while ago already.

If you think you need vs2017, please let us know why (generally vs2019 and vs2022 should be fully compatible). If it's really necessary, please use the dedicated mechanism in conda_build_config.yaml for that, i.e.

c_compiler:     # [win]
  - vs2017      # [win]
cxx_compiler:   # [win]
  - vs2017      # [win]

as opposed to specifying it in meta.yaml directly.

fbriol added a commit to fbriol/pyinterp-feedstock that referenced this issue Feb 4, 2024
fbriol added a commit that referenced this issue Feb 4, 2024
* Update version and sha256 in meta.yaml

* MNT: Re-rendered with conda-build 3.28.4, conda-smithy 3.30.4, and conda-forge-pinning 2024.02.04.07.53.20

* #97: Update windows compiler

* Update boost-cpp dependency to libboost-devel
@fbriol
Copy link
Contributor

fbriol commented Feb 4, 2024

The latest version 2024.1.0 takes this change into account.

@fbriol fbriol closed this as completed Feb 4, 2024
@h-vetinari
Copy link
Member Author

Thanks for the quick response! Just be aware that #98 did not yet rerender the feedstock after changing the compiler setup, so it'll probably pull in vs2022 currently, rather than the default vs2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants