Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows #26

Merged
merged 4 commits into from
Oct 16, 2022
Merged

Windows #26

merged 4 commits into from
Oct 16, 2022

Conversation

vincefn
Copy link
Contributor

@vincefn vincefn commented Oct 16, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This should enable windows build (but tests are expected to fail for python>=3.8)

@vincefn vincefn self-assigned this Oct 16, 2022
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@vincefn
Copy link
Contributor Author

vincefn commented Oct 16, 2022

The windows tests fail for python>=3.8, due to diffpy/pyobjcryst#33.
Otherwise all is good, we now have osx-arm64 builds, and a windows py3.7 build

@vincefn vincefn marked this pull request as ready for review October 16, 2022 20:42
@vincefn vincefn merged commit a7f3bff into conda-forge:main Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants