Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: Avoid deprecation warnings #3

Merged
merged 6 commits into from
Aug 17, 2022

Conversation

kbevers
Copy link
Contributor

@kbevers kbevers commented Feb 16, 2022

Patch supplied upstream [0] but the maintainer hasn't merged it and there
are signs of the project being abandoned. This is a temporary fix
until the future of the project is resolved.

[0] ktosiek/pytest-freezegun#36

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@kbevers kbevers force-pushed the patch-deprecation-warning branch from 0052f16 to 8015698 Compare February 16, 2022 18:13
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Patch supplied upstream [0] but the maintainer hasn't merged it and there
are signs of the project being abandoned. This is a temporary fix
until the future of the project is resolved.

[0] ktosiek/pytest-freezegun#36
@kbevers kbevers force-pushed the patch-deprecation-warning branch from 8015698 to 8814ae8 Compare February 16, 2022 18:15
@kbevers
Copy link
Contributor Author

kbevers commented Feb 16, 2022

@conda-forge-admin, please rerender

Copy link
Contributor

@duncanmmacleod duncanmmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, and apologies it took me so long to see it.

I presume that packaging should be added to requirements/run for this patch to work? Also marked a couple of typos. Thanks.

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
kbevers and others added 2 commits August 2, 2022 09:34
Co-authored-by: Duncan Macleod <duncanmmacleod+github@gmail.com>
Co-authored-by: Duncan Macleod <duncanmmacleod+github@gmail.com>
@kbevers
Copy link
Contributor Author

kbevers commented Aug 2, 2022

Thanks for this, and apologies it took me so long to see it.

No worries. Thanks for getting to it now though.

I presume that packaging should be added to requirements/run for this patch to work?

packaging is part of the standard library so I wouldn't think so. Unless conda-forge does weird stuff to it's Python distribution...

@duncanmmacleod
Copy link
Contributor

packaging is part of the standard library

I don't think that's right, at least I don't see it on https://docs.python.org/3/library/ and when I import it from my conda environment I get something in /site-packages/:

$ python3.10 -c "import packaging; print(packaging)"
<module 'packaging' from '/home/duncan/opt/mambaforge/envs/py310/lib/python3.10/site-packages/packaging/__init__.py'>

@kbevers
Copy link
Contributor Author

kbevers commented Aug 2, 2022

Indeed you are correct. My bad. I've fixed it in the most recent commit.

@duncanmmacleod duncanmmacleod added the automerge Merge the PR when CI passes label Aug 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing, but could not be merged (error=API error in POST to merge).

@kbevers
Copy link
Contributor Author

kbevers commented Aug 17, 2022

Is the PR good or do you need more input from me?

@duncanmmacleod duncanmmacleod merged commit 489e95f into conda-forge:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants