Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: 1.13.0 with new magma 2.6.2 #146

Closed
wants to merge 17 commits into from
Closed

Conversation

ngam
Copy link
Contributor

@ngam ngam commented Nov 5, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ngam ngam mentioned this pull request Nov 5, 2022
3 tasks
@ngam
Copy link
Contributor Author

ngam commented Nov 5, 2022

One thing we can do is to reduce the cuda arch list and see if it finishes on time. I will also run this locally tomorrow to test for myself...

@ngam ngam mentioned this pull request Nov 6, 2022
8 tasks
@@ -73,7 +71,7 @@ outputs:
# GPU requirements
- cudnn # [cuda_compiler_version != "None"]
- nccl # [cuda_compiler_version != "None"]
- magma # [cuda_compiler_version != "None"]
- magma 2.6.2 # [cuda_compiler_version != "None"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you have to be so specific.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just testing per the request here: conda-forge/magma-feedstock#20 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this is coming from my own channel, as I assume you have already figured

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Nov 6, 2022

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Nov 6, 2022

lets wait for magma to be released, then rebuild.

@ngam
Copy link
Contributor Author

ngam commented Nov 6, 2022

lets wait for magma to be released, then rebuild.

@carterbox wanted us to check before releasing the new version of magma, and I think it is safe for pytorch; but magma will likely not be released until a week or so from now according to the discussion in that PR.

@ngam
Copy link
Contributor Author

ngam commented Nov 6, 2022

It may make sense to merge #144 without the new magma. Then we can rebuild for magma alongside the patch release (it's been the case that pytorch minor releases have a quick patch release within a few weeks of late...)

Up to you though, I am in no particular rush 😃

@ngam ngam changed the title 1.13.0 with new magma 2.6.2 testing: 1.13.0 with new magma 2.6.2 Nov 6, 2022
@ngam ngam closed this Nov 6, 2022
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 5, 2022

We aren't as bad as Jax.... I just pushed to main to trigger a rebuild.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 5, 2022

Sorry, as bad as arrow.

@h-vetinari
Copy link
Member

Sorry, as bad as arrow.

What are you saying here? 🤔

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 5, 2022

then number of builds to rebuild. ^_^ juts a joke.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 5, 2022

arrow having 5 different branches, making it able to bog down azure ^_^

@h-vetinari
Copy link
Member

then number of builds to rebuild. ^_^ just a joke.

All good - sounds like you're gonna like conda-forge/arrow-cpp-feedstock#875; we're now down to 16 jobs (20 once CUDA on aarch/ppc is reinstated), and that's after doubling the build matrix due to openssl 3. And it runs faster (no more restarts 🥳), despite running the full test suite now.

arrow having 5 different branches, making it able to bog down azure ^_^

Yeah, I've set max_parallel on all branches, so it's not quite such a punch in the gut. 🙃

@ngam
Copy link
Contributor Author

ngam commented Dec 5, 2022

xref #144 (comment) (I think you meant to continue the convo there...)

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 5, 2022

Great work! These science packages are really hard to compile!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants