-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cuda12 rebuild #181
Cuda12 rebuild #181
Conversation
The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libblas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems [see this issue]( conda-forge/conda-forge.github.io#1963 ). Please feel free to raise any issues encountered there. Thank you! 🙏
…nda-forge-pinning 2023.06.06.09.57.57
Add use_mkldnn Add CFLAGS to silence gcc-12 false positive error
…nda-forge-pinning 2023.08.16.15.21.15
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
@conda-forge-admin, please re-render |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/pytorch-cpu-feedstock/actions/runs/5882478037. |
recipe/meta.yaml
Outdated
- mkl==2021.4.0 # [x86] | ||
- mkl-include==2021.4.0 # [x86] | ||
- mkl-devel==2021.4.0 # [x86]- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe these pins could be moved to conda_build_config.yaml
. Then when resolving upstream changes would prefer upstream's changes (then could readd the -devel
part). IIUC -include
comes with -devel
pytorch-cpu-feedstock/recipe/conda_build_config.yaml
Lines 10 to 13 in 229b447
blas_impl: | |
- mkl # [x86 or x86_64] | |
- generic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're also really old (>2 years). Do we really need to pin mkl that tightly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah am wondering the same. It also deviates from the current global pinnings
Maybe this was needed to get the build working, in which case there probably needs to be some investigation into how to bump the versions (and fix whatever issue occurs when using more recent versions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See this comment for the rationale: #172 (comment)
Thanks for picking this up @RaulPPelaez! |
The PR will also have to be rebased, or at least merged with |
I am having some success building locally. However, I am having trouble merging this with main, a lot of conflicts arise in files automatically created by the bot and I have no idea how to solve them. |
Ok I think I got it, I am closing this and continuing in #182 . |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)This is my take on trying to build for CUDA 12, its just a continuation of #171.
This builds locally on my machine, but is failing on testing because it does not find the mkl .so: