-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix run exports for libtorch and remove magma pinnings - Protobuf 4.25.3 #235
Conversation
The magma package as had run_exports for over a year now.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
…nda-forge-pinning 2024.05.06.18.03.21
NOTE: Rerendering has caused the CUDA 11.2 build to be removed as part of our channel's CUDA 11.2 EOL schedule, but I think all the reviewers of this package be should be aware of that by now. |
can you pull in the important changes from: #230 |
should we patch the magma pinning removal? |
Closes conda-forge#230 Co-authored-by: Bas Zalmstra <bas@prefix.dev>
Done.
The only benefit to using upstream run exports is that you don't download the dev files (headers, config) because we split magma into three packages: magma, libmagma, and libmagma_sparse. |
ok lets see if the builds pass for linux |
Thanks, Mark! |
libprotobuf: | ||
- 4.25.1 | ||
- 4.25.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, the brought pytorch up-to-date with the latest protobuf migration! 🥳
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)