Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix run exports for libtorch and remove magma pinnings - Protobuf 4.25.3 #235

Merged
merged 8 commits into from
May 8, 2024

Conversation

carterbox
Copy link
Member

@carterbox carterbox commented May 6, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libtorch' output doesn't have any tests.

@carterbox
Copy link
Member Author

NOTE: Rerendering has caused the CUDA 11.2 build to be removed as part of our channel's CUDA 11.2 EOL schedule, but I think all the reviewers of this package be should be aware of that by now.

@carterbox carterbox marked this pull request as ready for review May 6, 2024 19:09
@hmaarrfk
Copy link
Contributor

hmaarrfk commented May 6, 2024

can you pull in the important changes from: #230

@hmaarrfk
Copy link
Contributor

hmaarrfk commented May 6, 2024

should we patch the magma pinning removal?

Closes conda-forge#230

Co-authored-by: Bas Zalmstra <bas@prefix.dev>
@carterbox
Copy link
Member Author

can you pull in the important changes from: #230

Done.

should we patch the magma pinning removal?

The only benefit to using upstream run exports is that you don't download the dev files (headers, config) because we split magma into three packages: magma, libmagma, and libmagma_sparse.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented May 7, 2024

ok lets see if the builds pass for linux

@hmaarrfk hmaarrfk changed the title BUG: Fix run exports for libtorch and remove magma pinnings BUG: Fix run exports for libtorch and remove magma pinnings - Protobuf 4.25.3 May 8, 2024
@hmaarrfk hmaarrfk merged commit f9fd731 into conda-forge:main May 8, 2024
26 checks passed
@carterbox
Copy link
Member Author

Thanks, Mark!

@carterbox carterbox deleted the fix-run-exports branch May 8, 2024 16:43
Comment on lines 35 to +36
libprotobuf:
- 4.25.1
- 4.25.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, the brought pytorch up-to-date with the latest protobuf migration! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants