-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust OSX builds to avoid co-installed incompatible versions of OpenMP #244
Adjust OSX builds to avoid co-installed incompatible versions of OpenMP #244
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.06.21.08.07.40
aa7be0b
to
b0ffbab
Compare
lets see if we can recreate the failure in #245 |
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
@isuruf for my knowledge, have you tested the proposed fix? or do I need to think of a testing plan? My 8GB MacBook might not be able to compile this locally. Maybe I'll have to upload the build artifacts? |
As a followup, are we concerned to overloading the large runners? Should I continue to cancel the linux jobs even once we merge? |
Yes, I tested. You can also test this in an existing installation, by doing
|
You are correct: cd ${CONDA_PREFIX}/lib/python3.1/site-packages/torch/lib
rm libomp.dylib
ln -s ${CONDA_PREFIX}/lib/libomp.dylib
cd
python -c "import numpy; import torch; torch.zeros((1024, 1024), dtype=torch.uint8)" no longer segfaults |
Thank you for troubleshooting for this with me! |
I'm going to merge and cancel the linux builds to save linux users a 500MB+ download. |
Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #243.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.