Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 2.4.0 and add libpytorch.so to lib location #250

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Update to 2.4.0 and add libpytorch.so to lib location #250

merged 6 commits into from
Aug 23, 2024

Conversation

hmaarrfk
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author

This seems to work. I’m trying 11.8 locally with Isuru’s patch for libpytorch

after that I’ll push here for the CIs to build the whole matrix.

@hmaarrfk hmaarrfk marked this pull request as ready for review August 20, 2024 18:24
@hmaarrfk
Copy link
Contributor Author

@jeongseok-meta I think i got the changes that you requested for libpytorch.

cc: @h-vetinari @isuruf for an other set of eyes. If all is green I hope to merge on friday. LMK

@jeongseok-meta
Copy link
Contributor

@hmaarrfk Awesome, thank you for sorting the issue out!

@hmaarrfk hmaarrfk changed the title Update 2.4 Update to 2.4.0 and add libpytorch.so to lib location Aug 21, 2024
@hmaarrfk
Copy link
Contributor Author

alright, lets merge so we can take some of the heat on friday.

@hmaarrfk hmaarrfk merged commit 4314852 into conda-forge:main Aug 23, 2024
26 checks passed
@Tobias-Fischer Tobias-Fischer mentioned this pull request Aug 23, 2024
Closed
@jeongseok-meta
Copy link
Contributor

Great! Do we still need #246, as I see that the changes are already included in this PR?

@hmaarrfk
Copy link
Contributor Author

We will have to start a pytorch 2.4.0 migration tomorrow, so it may take a day or 3 for all the changes to propogate if you have dependnecies that depend on pytorch

@h-vetinari
Copy link
Member

Sorry I missed the ping, and thanks for fixing this!

@hmaarrfk
Copy link
Contributor Author

happy to help!

@jakirkham jakirkham mentioned this pull request Aug 24, 2024
Closed
facebook-github-bot pushed a commit to facebookincubator/momentum that referenced this pull request Aug 27, 2024
@jeongseok-meta @facebook-github-bot
Upgrade pytorch version to 2.4.0 (#59)
b34252a 
Summary:
to take the effect of conda-forge/pytorch-cpu-feedstock#250, which include `libtorch_python.so` in the libtorch pixi package that is required by pymomentum

Pull Request resolved: #59

Reviewed By: yutingye

Differential Revision: D61830940

fbshipit-source-id: da87c951c3a514ba7d4ff1864344ce75d5d55d34
This was referenced Aug 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobias-Fischer Tobias-Fischer Awaiting requested review from Tobias-Fischer Tobias-Fischer is a code owner

@beckermr beckermr Awaiting requested review from beckermr beckermr is a code owner

@benjaminrwilson benjaminrwilson Awaiting requested review from benjaminrwilson benjaminrwilson is a code owner

@sodre sodre Awaiting requested review from sodre sodre is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hmaarrfk @jeongseok-meta @h-vetinari @isuruf