Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.8 -> v1.9 #44

Merged
merged 13 commits into from
Jul 25, 2021
Merged

v1.8 -> v1.9 #44

merged 13 commits into from
Jul 25, 2021

Conversation

benjaminrwilson
Copy link
Contributor

@benjaminrwilson benjaminrwilson commented Jun 18, 2021

Checklist

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The outputs section contained an unexpected subsection name. activate_in_script is not a valid subsection name.

For recipe:

  • It looks like the 'pytorch-cpu' output doesn't have any tests.

@izahn
Copy link

izahn commented Jun 28, 2021

@conda-forge-admin please rerender

@benjaminrwilson
Copy link
Contributor Author

@isuruf, it appears that some of the Windows builds are immediately failing. Do you think we can just skip these?

@benjaminrwilson
Copy link
Contributor Author

@hmaarrfk, would you mind taking a look at this when you get a chance as well?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The outputs section contained an unexpected subsection name. activate_in_script is not a valid subsection name.

For recipe:

  • It looks like the 'pytorch-cpu' output doesn't have any tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The outputs section contained an unexpected subsection name. activate_in_script is not a valid subsection name.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@benjaminrwilson
Copy link
Contributor Author

@conda-forge/core, what is the best practice here for circumventing the Azure CI timeout? Is the only option to build locally?

@hmaarrfk
Copy link
Contributor

Currently yes. We have been buliding these packages manually on personally hardware. Rather tedious but dooable for linux.

Did you get the recipe updated? Seems like things are passing. Encouraging!

@benjaminrwilson
Copy link
Contributor Author

Ah, I see. Yes, the recipe is updated and seems to be working. I wonder if we could limit gpu architectures that this is being built against to try and get within the timeout limit.

recipe/meta.yaml Outdated Show resolved Hide resolved
@benjaminrwilson
Copy link
Contributor Author

@hmaarrfk and @isuruf, who previously built these locally? Do you think they'd be willing to help us out?

@hmaarrfk
Copy link
Contributor

I wonder if we should wait for the MKL migration as well. I think the bot is going to be doing an other round and starting a build soon. Do you want me to test building a CUDA build?

@benjaminrwilson
Copy link
Contributor Author

@hmaarrfk, a CUDA build would be much appreciated! I wonder if there's a way to split up the compute architecture builds into separate jobs (to try to avoid the CI timeout)?

@hmaarrfk
Copy link
Contributor

I might not have time to start one until Sunday Afternoon. For what its worth, you should be able to test local hardware with python build-locally.py

@hmaarrfk
Copy link
Contributor

My machiens are just currently in use.

@hmaarrfk
Copy link
Contributor

I'm kinda happy with this as is now.

A GPU build
https://anaconda.org/ramonaoptics/pytorch-gpu
https://anaconda.org/ramonaoptics/pytorch

Was successful.

@isuruf do we want to build them all here before merging?

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/build_pytorch.sh Outdated Show resolved Hide resolved
@hmaarrfk
Copy link
Contributor

@isuruf thank you for the review. I started a build tracker.

For those that want to help chose a build, and run the command:

python build-locally.py CONFIG_IN_THE_TABLE

and fill in the table with your name and start time (just so that we can get a feeling of the expected end date).

I started 4 at time on a largeish machine i have. I hope that the machine can handle it.

@hmaarrfk
Copy link
Contributor

nvm, on my computer, the disk is full..... managing the space taken by docker is no fun....

@isuruf
Copy link
Member

isuruf commented Jul 25, 2021

Please wait until the review is over and this Pr is merged

@hmaarrfk
Copy link
Contributor

ok, will do.

@hmaarrfk hmaarrfk mentioned this pull request Jul 25, 2021
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'pytorch-cpu' output doesn't have any tests.

@benjaminrwilson
Copy link
Contributor Author

@hmaarrfk and @isuruf, thanks for the reviews. Let me know if you have any other concerns.

@isuruf
Copy link
Member

isuruf commented Jul 25, 2021

@conda-forge-admin, rerender

@hmaarrfk hmaarrfk merged commit cf3bf46 into conda-forge:master Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants