Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Testing compatibility with NumPy 1.14 on Windows #18

Closed
wants to merge 2 commits into from

Conversation

jjhelmus
Copy link

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

I think this would need to add conda-forge/label/broken to channels/sources to work the way I'm guessing it is intended. Will also need to include conda-forge and defaults when making that change.

@jjhelmus
Copy link
Author

@jakirkham good call, I missed that numpy 1.14 had been moved to broken

@jjhelmus
Copy link
Author

This is not going to work, there are too many broken packages in broken! Let me move those packages into a different channel and try again.

@jakirkham
Copy link
Member

That or change the priority. Would put broken after cf personally.

@jjhelmus
Copy link
Author

The passing Python 3.6 build gives me enough to work with. NumPy 1.14 is fine for compiling C extensions, the issue, conda-forge/numpy-feedstock#79, is when Fortran code is present.

@jjhelmus
Copy link
Author

Testing done, closing.

@jjhelmus jjhelmus closed this Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants