Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for gstreamer122 and 5.15.8 and conda-forge cups #24

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update gstreamer122.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/4153715750, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk hmaarrfk changed the title Rebuild for gstreamer122 Rebuild for gstreamer122 and 5.15.8 and conda-forge cups Feb 12, 2023
@Tobias-Fischer
Copy link
Contributor

Hi @hmaarrfk - how does that look to you? If all looks good, I could locally build for linux-* and osx-*.

@Tobias-Fischer
Copy link
Contributor

Especially the loosening of the run_constrained is important I think, because currently we miss out on some migrations that have only been applied on qt-main 5.15.8 ..

@hmaarrfk
Copy link
Contributor

The problem with this recipe is always building everything.... I can't build windows....

@Tobias-Fischer
Copy link
Contributor

I could try building it on the windows conda-forge machine (and hope that 75gb of free space are sufficient to build this recipe)? But before doing that, let's make sure that the PR itself looks good?

@hmaarrfk
Copy link
Contributor

looks pretty standard to me. great job!

@Tobias-Fischer
Copy link
Contributor

Tobias-Fischer commented Feb 17, 2023

Ok - I triggered a Windows build, let's see how that goes. The other ones should be easier ..

Fixes #23

@Tobias-Fischer
Copy link
Contributor

Win build was successful - building the other platforms now.

@hmaarrfk
Copy link
Contributor

Great!! Did you remember to build the logs on windows? I've forgotten many times before

@hmaarrfk
Copy link
Contributor

Well going through the previous logs of #15 (comment)

it seems that we aren't even using many of these conda-forge packages.....

WARNING (qt-webengine): run-exports library package conda-forge::gstreamer-1.21.2-hd4edc92_0 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
WARNING (qt-webengine): run-exports library package conda-forge::libsqlite-3.40.0-h753d276_0 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
WARNING (qt-webengine): run-exports library package conda-forge::pulseaudio-16.1-h126f2b6_0 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
WARNING (qt-webengine): run-exports library package conda-forge::libwebp-1.2.4-h522a892_0 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
WARNING (qt-webengine): run-exports library package conda-forge::gst-plugins-base-1.21.2-h3e40eee_0 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
WARNING (qt-webengine): run-exports library package conda-forge::libxml2-2.10.3-h7463322_0 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
WARNING (qt-webengine): run-exports library package conda-forge::libiconv-1.17-h166bdaf_0 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
WARNING (qt-webengine): run-exports library package conda-forge::libglib-2.74.1-h606061b_1 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)

@Tobias-Fischer
Copy link
Contributor

Hi @hmaarrfk,

All packages can be found at https://anaconda.org/tobiasrobotics/qt-webengine with the label cfep03.

And here are all build logs:
build_log_aarch64.txt.zip
build_log_osx_arm64.txt.zip
build_log_osx64.txt.zip
build_log_linux64.txt.zip
build_log_win64.txt.zip

It would be great if you could move the packages to the conda-forge channel. In this way, users of qt-webengine can benefit from the recent migrations in qt-main 5.15.8. I suggest dealing with the non-used packages separately .. I can open an issue if you'd like.

Many thanks!

@isuruf
Copy link
Member

isuruf commented Feb 20, 2023

Can you please retain my author info for the commit from #23 ?

@Tobias-Fischer Tobias-Fischer force-pushed the rebuild-gstreamer122-0-1_h1312f5 branch from dd933df to 08071cf Compare February 20, 2023 21:22
@Tobias-Fischer
Copy link
Contributor

Done

@hmaarrfk
Copy link
Contributor

I suggest dealing with the non-used packages separately .. I can open an issue if you'd like.

agreed. Thank you for opening the issue.

The easiest might be to do a repodata patch, but it could also be that the sysroot packages are being found and used instead.

@hmaarrfk hmaarrfk merged commit 083f51c into conda-forge:main Feb 20, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-gstreamer122-0-1_h1312f5 branch February 20, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants